Method similarity_phone has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def similarity_phone p1, p2
return { full: 1.0,
distances: [1.0],
result: true } if p1 == p2 # exact match
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method similarity_phone has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def similarity_phone p1, p2
return { full: 1.0,
distances: [1.0],
result: true } if p1 == p2 # exact match
Method similarity_email has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def similarity_email e1, e2
return { full: 1.0,
name: 1.0,
domain: 1.0,
result: true } if e1 == e2- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Favor a normal if-statement over a modifier clause in a multiline statement. Open
return { full: 1.0,
name: 1.0,
domain: 1.0,
result: true } if e1 == e2- Read upRead up
- Exclude checks
Checks for uses of if/unless modifiers with multiple-lines bodies.
Example:
# bad
{
result: 'this should not happen'
} unless cond
# good
{ result: 'ok' } if cond%w-literals should be delimited by [ and ]. Open
COMPANY_NAME_STOP_WORDS = %w(ltd gmbh inc).freeze- Read upRead up
- Exclude checks
This cop enforces the consistent usage of %-literal delimiters.
Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.
Example:
# Style/PercentLiteralDelimiters:
# PreferredDelimiters:
# default: '[]'
# '%i': '()'
# good
%w[alpha beta] + %i(gamma delta)
# bad
%W(alpha #{beta})
# bad
%I(alpha beta)Favor a normal if-statement over a modifier clause in a multiline statement. Open
return { full: 1.0,
distances: [1.0],
result: true } if p1 == p2 # exact match- Read upRead up
- Exclude checks
Checks for uses of if/unless modifiers with multiple-lines bodies.
Example:
# bad
{
result: 'this should not happen'
} unless cond
# good
{ result: 'ok' } if condFavor a normal if-statement over a modifier clause in a multiline statement. Open
return { full: 1.0,
distances: [1.0] * c1.split(/\s+/).size,
matches: c1.split(/\s+/).size,
result: true } if c1 == c2 # exact match- Read upRead up
- Exclude checks
Checks for uses of if/unless modifiers with multiple-lines bodies.
Example:
# bad
{
result: 'this should not happen'
} unless cond
# good
{ result: 'ok' } if cond