Sign upLogin

ama-team/voxengine-stubs

View on GitHub
Star

Showing 12 of 12 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  var event = function (data) {
    var self = this
    data = data || {}
    Object.defineProperty(this, 'name', {value: fullName, writable: false})
    Object.keys(defaults).forEach(function (key) {
Severity: Major
Found in lib/Stub/CallEvents.js and 1 other location - About 5 hrs to fix
lib/Stub/AppEvents.js on lines 6..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  var event = function (data) {
    var self = this
    data = data || {}
    Object.defineProperty(this, 'name', {value: fullName, writable: false})
    Object.keys(defaults).forEach(function (key) {
Severity: Major
Found in lib/Stub/AppEvents.js and 1 other location - About 5 hrs to fix
lib/Stub/CallEvents.js on lines 6..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Manager has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Manager (context) {
  var self = this
  context = context || global
  self._settings = {}
  self._stash = null
Severity: Major
Found in lib/Manager.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      this.reset = function () {
    eachSymbol(function (symbol) {
      context[symbol] && context[symbol]._reset && context[symbol]._reset()
    })
  }
    Severity: Major
    Found in lib/Manager.js and 1 other location - About 1 hr to fix
    lib/Manager.js on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      this.flush = function () {
    eachSymbol(function (symbol) {
      context[symbol] && context[symbol]._flush && context[symbol]._flush()
    })
  }
    Severity: Major
    Found in lib/Manager.js and 1 other location - About 1 hr to fix
    lib/Manager.js on lines 72..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function httpRequest has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        httpRequest: function (self, url, callback, options) {
      if (!self._state.http.responses) {
        self._state.http.responses = self._settings.http.responses.slice()
      }
      var responses = self._state.http.responses
    Severity: Minor
    Found in lib/Stub/Net.js - About 1 hr to fix

      Function create has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        create: function (symbol, settings) {
    var mock = function (configuration) {
      var self = this
      this.name = symbol
      Severity: Minor
      Found in lib/Stub/Factory.js - About 1 hr to fix

        Function mock has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var mock = function (configuration) {
      var self = this
      this.name = symbol

      this._setup = function (configuration) {
        Severity: Minor
        Found in lib/Stub/Factory.js - About 1 hr to fix

          Function onFlush has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            onFlush: function (self) {
    var allure = self._settings.allure
    if (!allure.enabled || !global.allure) {
      return
    }
          Severity: Minor
          Found in lib/Stub/VoxEngine.js - About 1 hr to fix

            Function chain has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              chain: function (tasks, suppressErrors, callback) {
    var errors = []
    callback = callback || function (error, value) {
      error ? fail(error) : complete(value)
    }
            Severity: Minor
            Found in tasks/Support/index.js - About 1 hr to fix

              Function Manager has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function Manager (context) {
  var self = this
  context = context || global
  self._settings = {}
  self._stash = null
              Severity: Minor
              Found in lib/Manager.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function httpRequest has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  httpRequest: function (self, url, callback, options) {
      if (!self._state.http.responses) {
        self._state.http.responses = self._settings.http.responses.slice()
      }
      var responses = self._state.http.responses
              Severity: Minor
              Found in lib/Stub/Net.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language