amahi/platform

View on GitHub
app/controllers/search_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method locate_search has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def locate_search(term, filter, page, rpp)
        base = Share.basenames
        # lines to skip
        skip = (page - 1) * rpp
        open locate_cache(term) do |l|
Severity: Minor
Found in app/controllers/search_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hda has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def hda
        @page_title = 'Search Results'
        @search_value = 'HDA'

        if params[:button] && params[:button] == "Web"
Severity: Minor
Found in app/controllers/search_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if params[:button] && params[:button] == "Web"
            require 'uri'
            redirect_to URI.escape("http://www.google.com/search?q=#{params[:query]}")
        else
            @query = params[:query]
Severity: Major
Found in app/controllers/search_controller.rb - About 40 mins to fix

    Method locate_cache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def locate_cache(term)
            FileUtils.mkdir_p(SEARCH_CACHE)
            sha1 = Digest::SHA1.hexdigest(term)
            cache = File.join(SEARCH_CACHE, sha1)
            # expire old entries in the cache to prevent accumulation (12 hours, index is 24 hours old)
    Severity: Minor
    Found in app/controllers/search_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def video
            @query = params[:query]
            @page = (params[:page] && params[:page].to_i.abs) || 1
            @rpp = (params[:per_page] && params[:per_page].to_i.abs) || RESULTS_PER_PAGE
            @results = hda_search(@query, EXT_VIDEO, @page, @rpp)
    Severity: Major
    Found in app/controllers/search_controller.rb and 2 other locations - About 40 mins to fix
    app/controllers/search_controller.rb on lines 53..58
    app/controllers/search_controller.rb on lines 61..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def audio
            @query = params[:query]
            @page = (params[:page] && params[:page].to_i.abs) || 1
            @rpp = (params[:per_page] && params[:per_page].to_i.abs) || RESULTS_PER_PAGE
            @results = hda_search(@query, EXT_AUDIO, @page, @rpp)
    Severity: Major
    Found in app/controllers/search_controller.rb and 2 other locations - About 40 mins to fix
    app/controllers/search_controller.rb on lines 53..58
    app/controllers/search_controller.rb on lines 69..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def images
            @query = params[:query]
            @page = (params[:page] && params[:page].to_i.abs) || 1
            @rpp = (params[:per_page] && params[:per_page].to_i.abs) || RESULTS_PER_PAGE
            @results = hda_search(@query, EXT_IMAGES, @page, @rpp)
    Severity: Major
    Found in app/controllers/search_controller.rb and 2 other locations - About 40 mins to fix
    app/controllers/search_controller.rb on lines 61..66
    app/controllers/search_controller.rb on lines 69..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status