Sign upLogin

amahi/platform

View on GitHub
Star
app/models/server.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Server has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class Server < ApplicationRecord

    # CAUTION - this class *assumes* new servers are created
    # started and enabled at boot time as services!
Severity: Minor
Found in app/models/server.rb - About 2 hrs to fix

    Method estimate_pids has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def estimate_pids
        pf = pid_file
        ret = []
        begin
            # check if the pid file is there
    Severity: Minor
    Found in app/models/server.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method before_save_hook has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def before_save_hook
        if monitored_changed?
            monitored ? monit_file_add : monit_file_remove
            # DEBUG RAILS_DEFAULT_LOGGER.info "* * * MONITORED CHANGED to #{monitored}"
        end
    Severity: Minor
    Found in app/models/server.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status