Sign upLogin

amahi/platform

View on GitHub
Star
app/models/share.rb

Summary

Maintainability
D
2 days
Test Coverage

File share.rb has 398 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'command'
require 'platform'
require 'temp_cache'

class Share < ApplicationRecord
Severity: Minor
Found in app/models/share.rb - About 5 hrs to fix

    Class Share has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Share < ApplicationRecord

    DEFAULT_SHARES_ROOT = '/var/hda/files'

    SIGNATURE = "Amahi configuration"
    Severity: Minor
    Found in app/models/share.rb - About 3 hrs to fix

      Method share_conf has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          def share_conf
        ret = "[%s]\n"        \
        "\tcomment = %s\n"     \
        "\tpath = %s\n"     \
        "\twriteable = %s\n"     \
      Severity: Minor
      Found in app/models/share.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method header_pdc has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.header_pdc(domain)
        short_domain = Setting.shares.value_by_name("workgroup") || 'workgroup'
        debug = Setting.shares.value_by_name('debug') == '1'
        admins = User.admins rescue ["no_such_user"]
        ret = ["# This file is automatically generated for PDC setup.",
      Severity: Major
      Found in app/models/share.rb - About 2 hrs to fix

        Method header_workgroup has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.header_workgroup(domain)
        short_domain = Setting.find_or_create_by(Setting::GENERAL, 'workgroup', 'WORKGROUP').value
        debug = Setting.shares.value_by_name('debug') == '1'
        win98 = Setting.shares.value_by_name('win98') == '1'
        ret = ["# This file is automatically generated for WORKGROUP setup.",
        Severity: Minor
        Found in app/models/share.rb - About 1 hr to fix

          Method share_conf has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def share_conf
        ret = "[%s]\n"        \
        "\tcomment = %s\n"     \
        "\tpath = %s\n"     \
        "\twriteable = %s\n"     \
          Severity: Minor
          Found in app/models/share.rb - About 1 hr to fix

            Method before_save_hook has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def before_save_hook
        if guest_writeable_changed?
            guest_writeable ? make_guest_writeable : make_guest_non_writeable
        end
        self.tags = self.tags.split(/\s*,\s*|\s+/).reject {|s| s.empty? }.join(', ').downcase if self.tags_changed?
            Severity: Minor
            Found in app/models/share.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def toggle_access!(user_id)
        unless self.everyone
            user = User.find(user_id)
            if self.users_with_share_access.include? user
                self.users_with_share_access -= [user]
            Severity: Minor
            Found in app/models/share.rb and 1 other location - About 15 mins to fix
            app/models/share.rb on lines 203..212

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def toggle_write!(user_id)
        unless self.everyone
            user = User.find(user_id)
            if self.users_with_write_access.include? user
                self.users_with_write_access -= [user]
            Severity: Minor
            Found in app/models/share.rb and 1 other location - About 15 mins to fix
            app/models/share.rb on lines 191..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status