Sign upLogin

amahi/platform

View on GitHub
Star
plugins/020-shares/app/controllers/shares_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class SharesController has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class SharesController < ApplicationController

    before_action :admin_required

    before_action :get_share
Severity: Minor
Found in plugins/020-shares/app/controllers/shares_controller.rb - About 2 hrs to fix

    Method update_workgroup has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_workgroup
        sleep 2 if development?
        @workgroup = Setting.find(params[:id]) if params[:id]
        if @workgroup && @workgroup.name.eql?("workgroup")
            params[:share][:value].strip!
    Severity: Minor
    Found in plugins/020-shares/app/controllers/shares_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_size has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_size
        sleep 1 if development?
        begin
            std_out, status = Open3.capture2e("du -sbL #{@share.path}")
            size = std_out.split(' ').first
    Severity: Minor
    Found in plugins/020-shares/app/controllers/shares_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status