Sign upLogin

amatriain/feedbunch

View on GitHub
Star
FeedBunch-app/lib/url_subscriber.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method subscribe_new_feed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def self.subscribe_new_feed(user, feed_url)
    Rails.logger.info "Feed #{feed_url} not in the database, trying to fetch it"
    feed = Feed.create! fetch_url: feed_url, title: feed_url
    begin
      fetched_feed = FeedClient.fetch feed, http_caching: false, perform_autodiscovery: true
Severity: Minor
Found in FeedBunch-app/lib/url_subscriber.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status