Sign upLogin

amatriain/openreader

View on GitHub
Star
FeedBunch-app/app/workers/subscribe_user_worker.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method perform has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def perform(user_id, feed_url, job_state_id)
    # Find the SubscribeJobState instance for this job, if it exists
    if SubscribeJobState.exists? job_state_id
      job_state = SubscribeJobState.find job_state_id
      # Check that the subscribe_job_state is in state "RUNNING"
Severity: Minor
Found in FeedBunch-app/app/workers/subscribe_user_worker.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform(user_id, feed_url, job_state_id)
    # Find the SubscribeJobState instance for this job, if it exists
    if SubscribeJobState.exists? job_state_id
      job_state = SubscribeJobState.find job_state_id
      # Check that the subscribe_job_state is in state "RUNNING"
Severity: Minor
Found in FeedBunch-app/app/workers/subscribe_user_worker.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status