Sign upLogin

amatsuda/active_decorator

View on GitHub
Star
lib/active_decorator/decorator.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method decorate has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def decorate(obj)
      return obj if defined?(Jbuilder) && (Jbuilder === obj)

      case obj
      when Array
Severity: Minor
Found in lib/active_decorator/decorator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decorator_for has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def decorator_for(model_class)
      return @decorators[model_class] if @decorators.key? model_class

      decorator_name = "#{model_class.name}#{ActiveDecorator.config.decorator_suffix}"
      d = decorator_name.constantize
Severity: Minor
Found in lib/active_decorator/decorator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method decorate_relation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def decorate_relation(obj)
      if obj.respond_to?(:records)
        # Rails 5.0
        obj.extend ActiveDecorator::RelationDecorator unless ActiveDecorator::RelationDecorator === obj
      else
Severity: Minor
Found in lib/active_decorator/decorator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status