amcgee/remjs

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var skipHandler = function( req ) {
    if ( req.method !== 'GET' || !req.query.skip ) {
        return null;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var limitHandler = function( req ) {
    if ( req.method !== 'GET' || !req.query.limit ) {
        return null;
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        return req.rem.db.update({ _id: doc._id }, { $set: obj }, {})
        .then(function(numReplaced) {
            if ( numReplaced === 0 ) {
                res.status(404).send("Resource update failed.");
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        return req.rem.db.update({ _id: doc._id }, obj, {})
        .then(function(numReplaced) {
            if ( numReplaced === 0 ) {
                res.status(404).send("Resource update failed.");
            }

• Read up
  Read up

Function meRouter has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

Authenticator.prototype.meRouter = function() {
    var meRouter = express.Router();

    meRouter.use( function(req, res, next) {
        if ( !req.rem.identity ) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

MongoEngine.prototype.collection = function(name) {
    if ( !this.collections[name] ) {
        this.collections[name] = new MongoCollection(this, name);
    }
    return this.collections[name];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _.forEach( this.filter, function( v, i ) {
        if ( _.isFunction(v) ) {
            query[i] = v(resource,req);
        } else {
            query[i] = v;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

SQLEngine.prototype.collection = function(name) {
    if ( !this.collections[name] ) {
        this.collections[name] = new SQLCollection(this, name);
    }
    return this.collections[name];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _.forEach( this.defaults, function( v, i ) {
        if ( _.isFunction(v) ) {
            obj[i] = v(resource,req);
        } else {
            obj[i] = v;

• Read up
  Read up

Function REMResource has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var REMResource = function(name, opt, parent) {
    this.router = express.Router();
    this.name = name;
    this.options = new REMOptions(this, opt, parent);
    this.permissions = new PermissionsManager(this);

Function handler has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var handler = function(req, res) {
    if ( !_.isObject( req.body ) ) {
        res.status(400).send("Invalid request body.");
    }
    if ( !req.rem.db.findOne || !req.rem.db.update ) {

Function handler has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var handler = function(req, res) {
    if ( !_.isObject( req.body ) ) {
        res.status(400).send("Invalid request body.");
    }
    if ( !req.rem.db.findOne || !req.rem.db.update ) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    options.filter[parent.options.makeForeignKey(parent.name)] = function(resource, req) {
        return req.rem.bound_id[parent.name];
    }.bind(this);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    options.defaults[parent.options.makeForeignKey(parent.name)] = function(resource, req) {
        return req.rem.bound_id[parent.name];
    }.bind(this);

• Read up
  Read up

Function create has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

LoginHelper.prototype.create = function( login, password, misc, callback ) {
    return this.lookup( { login: login } )
    .bind(this)
    .then( function() {
        throw new LoginAlreadyExistsError();

Function lookup has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

LoginHelper.prototype.lookup = function( candidate, with_sensitive, callback ) {
    var query = {};
    if ( candidate._id ) {
        query._id = candidate._id;
    }

Function handler has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var handler = function(req, res) {
    if ( !_.isObject( req.body ) ) {
        res.status(400).send("Invalid request body.");
    }
    if ( !req.rem.db.insert ) {

Function update has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function( login, old_password, new_password, misc, callback ) {
    var identity = null;

    return this.check( login, old_password )
    .bind(this)

Function parse has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

JWT.prototype.parse = function( token, callback ) {
    return BPromise.try( function() {
        return jwt.decode( token, this.secret );
    }.bind(this) )
    .bind(this)

Function createRouter has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

REM.prototype.createRouter = function() {
    var router = express.Router();

    router.use( function(req, res, next) {
        req.rem = {};