Sign upLogin

amcgee/remjs

View on GitHub
Star
lib/plugins/auth_helpers/login.js

Summary

Maintainability
C
1 day
Test Coverage

Function create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

LoginHelper.prototype.create = function( login, password, misc, callback ) {
    return this.lookup( { login: login } )
    .bind(this)
    .then( function() {
        throw new LoginAlreadyExistsError();
Severity: Minor
Found in lib/plugins/auth_helpers/login.js - About 1 hr to fix

    Function lookup has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    LoginHelper.prototype.lookup = function( candidate, with_sensitive, callback ) {
    var query = {};
    if ( candidate._id ) {
        query._id = candidate._id;
    }
    Severity: Minor
    Found in lib/plugins/auth_helpers/login.js - About 1 hr to fix

      Function update has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function( login, old_password, new_password, misc, callback ) {
    var identity = null;

    return this.check( login, old_password )
    .bind(this)
      Severity: Minor
      Found in lib/plugins/auth_helpers/login.js - About 1 hr to fix

        Function check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        LoginHelper.prototype.check = function( login, password, callback ) {
    var identity = null;
    return this.lookup( { login: login }, true )
    .bind(this)
    .catch( function( err ) {
        Severity: Minor
        Found in lib/plugins/auth_helpers/login.js - About 1 hr to fix

          Function update has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function( login, old_password, new_password, misc, callback ) {
          Severity: Minor
          Found in lib/plugins/auth_helpers/login.js - About 35 mins to fix

            Function LoginHelper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            var LoginHelper = function(options, resources) {
    this.authority = _.clone( options.login_authority || { resource: 'users' } );
    if ( !this.authority.resource ) {
        throw new Error( "Bad login authority " + JSON.stringify( this.authority ) );
    }
            Severity: Minor
            Found in lib/plugins/auth_helpers/login.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    updated_login[this.authority.auth_property] = {
            encrypted_password: result.key,
            salt: result.salt,
            iterations: result.iterations
        };
            Severity: Minor
            Found in lib/plugins/auth_helpers/login.js and 1 other location - About 35 mins to fix
            lib/plugins/auth_helpers/login.js on lines 138..142

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    new_login[this.authority.auth_property] = {
            encrypted_password: result.key,
            salt: result.salt,
            iterations: result.iterations
        };
            Severity: Minor
            Found in lib/plugins/auth_helpers/login.js and 1 other location - About 35 mins to fix
            lib/plugins/auth_helpers/login.js on lines 166..170

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            var BadPasswordError = function() {
    this.message = "Bad login password.";
    this.name = "BadPasswordError";
    Error.captureStackTrace(this, BadPasswordError);
};
            Severity: Minor
            Found in lib/plugins/auth_helpers/login.js and 2 other locations - About 35 mins to fix
            lib/plugins/auth_helpers/login.js on lines 5..9
            lib/plugins/auth_helpers/login.js on lines 13..17

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            var LoginAlreadyExistsError = function() {
    this.message = "Login already exists.";
    this.name = "LoginAlreadyExistsError";
    Error.captureStackTrace(this, LoginAlreadyExistsError);
};
            Severity: Minor
            Found in lib/plugins/auth_helpers/login.js and 2 other locations - About 35 mins to fix
            lib/plugins/auth_helpers/login.js on lines 5..9
            lib/plugins/auth_helpers/login.js on lines 21..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            var LoginNotFoundError = function() {
    this.message = "Login does not exist.";
    this.name = "LoginNotFoundError";
    Error.captureStackTrace(this, LoginNotFoundError);
};
            Severity: Minor
            Found in lib/plugins/auth_helpers/login.js and 2 other locations - About 35 mins to fix
            lib/plugins/auth_helpers/login.js on lines 13..17
            lib/plugins/auth_helpers/login.js on lines 21..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status