Sign upLogin

americanexpress/xcode-result-bundle-processor

View on GitHub
Star
lib/xcoderesultbundleprocessor/test_summaries/html_report.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Assignment Branch Condition size for _format_test is too high. [58.39/20]
Open

      def _format_test(test, mab, destination_dir)
        mab.a name: test.identifier do
          if test.passed?
            mab.h2 test.summary
          else
Severity: Minor
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for save is too high. [44.23/20]
Open

      def save(destination_dir)
        info "Saving HTML report to #{destination_dir}"

        raise "Destination directory #{destination_dir} already exists" if Dir.exist?(destination_dir)
Severity: Minor
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method _format_test has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

      def _format_test(test, mab, destination_dir)
        mab.a name: test.identifier do
          if test.passed?
            mab.h2 test.summary
          else
Severity: Minor
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _format_test has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def _format_test(test, mab, destination_dir)
        mab.a name: test.identifier do
          if test.passed?
            mab.h2 test.summary
          else
Severity: Major
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb - About 2 hrs to fix

Method save has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def save(destination_dir)
        info "Saving HTML report to #{destination_dir}"

        raise "Destination directory #{destination_dir} already exists" if Dir.exist?(destination_dir)
Severity: Minor
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb - About 1 hr to fix

There are no issues that match your filters.

Category
Status