Sign upLogin

amolpujari/saw

View on GitHub
Star

Showing 3 of 3 total issues

Method saw has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def saw doing=nil, json_data=nil, associated_object=nil
      user_id     = current_user ? current_user.id : nil
      session_id  = request.session_options[:id]
      remote_host = request.remote_ip
      remote_host = request.env["HTTP_X_FORWARDED_FOR"] if remote_host.blank?
Severity: Minor
Found in lib/saw/controller.rb - About 1 hr to fix

    Method saw has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def saw doing=nil, json_data=nil, associated_object=nil
      user_id     = current_user ? current_user.id : nil
      session_id  = request.session_options[:id]
      remote_host = request.remote_ip
      remote_host = request.env["HTTP_X_FORWARDED_FOR"] if remote_host.blank?
    Severity: Minor
    Found in lib/saw/controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method time_diff has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.time_diff dt1, dt2
      diff = nil
      #diff   = 1 unless dt1 or dt1.kind_of? DateTime
      #diff ||= 1 unless dt2 or dt2.kind_of? DateTime
      diff ||= dt2 - dt1
    Severity: Minor
    Found in lib/saw/util.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language