Call to method show_box_top
from undeclared class \Ampache\Module\Util\Ui
Open
<?php Ui::show_box_top(T_('Albums of the Moment') . ' ' . $button, 'box box_random_albums'); ?>
- Exclude checks
Call to method show_box_bottom
from undeclared class \Ampache\Module\Util\Ui
Open
<?php Ui::show_box_bottom(); ?>
- Exclude checks
Call to method __construct
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
$albumDisk = new AlbumDisk($album_disk_id);
- Exclude checks
Call to method display_art
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
$albumDisk->display_art($thumb, true); ?>
- Exclude checks
Call to method is_grid_view
from undeclared class \Ampache\Module\Util\Ui
Open
if (!Ui::is_grid_view('album')) {
- Exclude checks
Call to method check_autoplay_next
from undeclared class \Ampache\Module\Playback\Stream_Playlist
Open
<?php if (Stream_Playlist::check_autoplay_next()) { ?>
- Exclude checks
Reference to instance property id
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
<?php echo Ajax::button('?action=basket&type=album_disk&id=' . $albumDisk->id, 'add', T_('Add to Temporary Playlist'), 'play_full_' . $albumDisk->id); ?>
- Exclude checks
Reference to instance property id
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
<span class="cel_rating" id="rating_<?php echo $albumDisk->id; ?>_album"><?php echo Rating::show($albumDisk->id, 'album_disk'); ?></span>
- Exclude checks
Call to method show
from undeclared class \Ampache\Repository\Model\Userflag
Open
<span class="cel_rating" id="userflag_<?php echo $albumDisk->id; ?>_album"><?php echo Userflag::show($albumDisk->id, 'album_disk'); ?></span>
- Exclude checks
Call to method show
from undeclared class \Ampache\Repository\Model\Rating
Open
<span class="cel_rating" id="rating_<?php echo $albumDisk->id; ?>_album"><?php echo Rating::show($albumDisk->id, 'album_disk'); ?></span>
- Exclude checks
Reference to instance property id
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
<?php echo Ajax::button('?page=stream&action=directplay&object_type=album_disk&object_id=' . $albumDisk->id, 'play', T_('Play'), 'play_album_disk_' . $albumDisk->id); ?>
- Exclude checks
Reference to instance property id
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
<?php echo Ajax::button('?page=stream&action=directplay&object_type=album_disk&object_id=' . $albumDisk->id . '&append=true', 'play_add', T_('Play last'), 'addplay_album_disk_' . $albumDisk->id); ?>
- Exclude checks
Call to deprecated function \Ampache\Module\Authorization\Access::check()
defined at /code/src/Module/Authorization/Access.php:154
Open
if (Access::check('interface', 25)) { ?>
- Exclude checks
Reference to instance property id
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
<span class="cel_rating" id="userflag_<?php echo $albumDisk->id; ?>_album"><?php echo Userflag::show($albumDisk->id, 'album_disk'); ?></span>
- Exclude checks
Reference to instance property id
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
<?php echo Ajax::button('?page=stream&action=directplay&object_type=album_disk&object_id=' . $albumDisk->id . '&playnext=true', 'play_next', T_('Play next'), 'nextplay_album_disk_' . $albumDisk->id); ?>
- Exclude checks
Call to method check_autoplay_append
from undeclared class \Ampache\Module\Playback\Stream_Playlist
Open
<?php if (Stream_Playlist::check_autoplay_append()) { ?>
- Exclude checks
Call to method format
from undeclared class \Ampache\Repository\Model\AlbumDisk
Open
$albumDisk->format();
- Exclude checks
Define a constant instead of duplicating this literal "?page=stream&action=directplay&object_type=album_disk&object_id=" 3 times. Open
<?php echo Ajax::button('?page=stream&action=directplay&object_type=album_disk&object_id=' . $albumDisk->id, 'play', T_('Play'), 'play_album_disk_' . $albumDisk->id); ?>
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
declare(strict_types=0);
/**
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 477.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Line indented incorrectly; expected at least 12 spaces, found 8 Open
$albumDisk->display_art($thumb, true); ?>
- Exclude checks
Closing brace indented incorrectly; expected 12 spaces, found 16 Open
<?php } ?>
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
$thumb = 11;
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
}
- Exclude checks
Line indented incorrectly; expected at least 16 spaces, found 12 Open
$show_play = false;
- Exclude checks
Line indented incorrectly; expected 12 spaces, found 8 Open
if (!Ui::is_grid_view('album')) {
- Exclude checks