Sign upLogin

ampache/ampache

View on GitHub
Star
src/Application/Api/Ajax/Handler/SearchAjaxHandler.php

Summary

Maintainability
F
3 days
Test Coverage

handle accesses the super-global variable $_REQUEST.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

handle accesses the super-global variable $_REQUEST.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

handle accesses the super-global variable $_SESSION.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

handle accesses the super-global variable $_REQUEST.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

handle accesses the super-global variable $_REQUEST.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

handle accesses the super-global variable $_SESSION.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function handle has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Minor
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has 230 lines of code (exceeds 200 allowed). Consider refactoring.
Open

    public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
Severity: Major
Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php - About 2 hrs to fix

    The method handle() has 259 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
    Severity: Minor
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

    The method handle() has an NPath complexity of 10478163. The configured NPath complexity threshold is 200.
    Open

        public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
    Severity: Minor
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method handle() has a Cyclomatic Complexity of 44. The configured cyclomatic complexity threshold is 10.
    Open

        public function handle(): void
    {
        $results = array();
        $action  = $this->requestParser->getFromRequest('action');
    Severity: Minor
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The class SearchAjaxHandler has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
    Open

    final class SearchAjaxHandler implements AjaxHandlerInterface
{
    private RequestParserInterface $requestParser;

    private ConfigContainerInterface $configContainer;
    Severity: Minor
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    syntax error, unexpected 'RequestParserInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
    Open

        private RequestParserInterface $requestParser;
    Severity: Critical
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php by phan

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (($target == 'anywhere' && $album_group) || $target == 'album') {
                    $searchreq = array(
                        'limit' => $limit,
                        'type' => 'album',
                        'rule_1_input' => $search,
    Severity: Major
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php and 1 other location - About 1 day to fix
    src/Application/Api/Ajax/Handler/SearchAjaxHandler.php on lines 137..163

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 256.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (($target == 'anywhere' && !$album_group) || $target == 'album_disk') {
                    $searchreq = array(
                        'limit' => $limit,
                        'type' => 'album_disk',
                        'rule_1_input' => $search,
    Severity: Major
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php and 1 other location - About 1 day to fix
    src/Application/Api/Ajax/Handler/SearchAjaxHandler.php on lines 109..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 256.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                case 'search_random':
                if (!Access::check('interface', 75)) {
                    echo (string) xoutput_from_array(array('rfc3514' => '0x1'));

                    return;
    Severity: Major
    Found in src/Application/Api/Ajax/Handler/SearchAjaxHandler.php and 1 other location - About 2 hrs to fix
    src/Application/Api/Ajax/Handler/DemocraticPlaybackAjaxHandler.php on lines 79..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 121.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status