Sign upLogin

ampache/ampache

View on GitHub
Star
src/Module/Api/Method/Api4/Artists4Method.php

Summary

Maintainability
D
1 day
Test Coverage

Call to method set_limit from undeclared class \Ampache\Module\Api\Json4_Data
Open

                Json4_Data::set_limit($input['limit'] ?? 0);
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Call to method set_offset from undeclared class \Ampache\Module\Api\Json4_Data
Open

                Json4_Data::set_offset($input['offset'] ?? 0);
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Call to method artists from undeclared class \Ampache\Module\Api\Xml4_Data
Open

                echo Xml4_Data::artists($results, $include, $user);
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Call to method set_offset from undeclared class \Ampache\Module\Api\Xml4_Data
Open

                Xml4_Data::set_offset($input['offset'] ?? 0);
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Call to method set_limit from undeclared class \Ampache\Module\Api\Xml4_Data
Open

                Xml4_Data::set_limit($input['limit'] ?? 0);
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Parameter $user has undeclared type \Ampache\Repository\Model\User
Open

    public static function artists(array $input, User $user): void
Severity: Minor
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Call to method getBrowse from undeclared class \Ampache\Module\Api\Api
Open

        $browse = Api::getBrowse();
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Call to method artists from undeclared class \Ampache\Module\Api\Json4_Data
Open

                echo Json4_Data::artists($results, $include, $user);
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by phan

Define a constant instead of duplicating this literal "include" 4 times.
Open

        if (array_key_exists('include', $input)) {
Severity: Critical
Found in src/Module/Api/Method/Api4/Artists4Method.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=0);

/**
Severity: Major
Found in src/Module/Api/Method/Api4/Artists4Method.php and 1 other location - About 1 day to fix
src/Module/Api/Method/Api4/Albums4Method.php on lines 1..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 375.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status