Function gatherFileArt
has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring. Open
public static function gatherFileArt($file): array
{
try {
$getID3 = new getID3();
$id3 = $getID3->analyze($file);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class MetaTagCollectorModule has an overall complexity of 71 which is very high. The configured complexity threshold is 50. Open
final class MetaTagCollectorModule implements CollectorModuleInterface
{
private const TAG_ALBUM_ART_PRIORITY = array(
'ID3 Front Cover',
'ID3 Illustration',
- Exclude checks
Function gatherSongTags
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function gatherSongTags(Art $art, int $limit = 5): array
{
// We need the filenames
if ($art->type == 'album') {
$songs = $this->songRepository->getByAlbum($art->uid);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function collect
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function collect(
Art $art,
int $limit = 5,
array $data = []
): array {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return 'Leaflet';
Avoid too many return
statements within this method. Open
return 'Band';
Avoid too many return
statements within this method. Open
return 'Artist';
Avoid too many return
statements within this method. Open
return 'Lead Artist';
Avoid too many return
statements within this method. Open
return 'Lyricist';
Avoid too many return
statements within this method. Open
return 'Composer';
Avoid too many return
statements within this method. Open
return 'Conductor';
Avoid too many return
statements within this method. Open
return 'Media';
Avoid too many return
statements within this method. Open
return 'Recording Studio or Location';
Avoid too many return
statements within this method. Open
return 'Bright(ly) Colored Fish';
Avoid too many return
statements within this method. Open
return 'Band Logo';
Avoid too many return
statements within this method. Open
return 'Publisher Logo';
Avoid too many return
statements within this method. Open
return 'Recording Session';
Avoid too many return
statements within this method. Open
return 'Illustration';
Avoid too many return
statements within this method. Open
return 'Performance';
Avoid too many return
statements within this method. Open
return 'Other';
Avoid too many return
statements within this method. Open
return 'Capture from Movie or Video';
The method gatherFileArt() has an NPath complexity of 8250. The configured NPath complexity threshold is 200. Open
public static function gatherFileArt($file): array
{
try {
$getID3 = new getID3();
$id3 = $getID3->analyze($file);
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method gatherFileArt() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10. Open
public static function gatherFileArt($file): array
{
try {
$getID3 = new getID3();
$id3 = $getID3->analyze($file);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getPictureType() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10. Open
public static function getPictureType(int $picture_type): string
{
switch ($picture_type) {
case 1:
return '32x32 PNG Icon';
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method collect uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$data = [];
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method gatherSongTags uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$songs = $this->songRepository->getByArtist($art->uid);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
syntax error, unexpected 'LoggerInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open
private LoggerInterface $logger;
- Exclude checks
Similar blocks of code found in 3 locations. Consider refactoring. Open
if (isset($id3['id3v2']['PIC'])) {
// Foreach in case they have more than one
foreach ($id3['id3v2']['PIC'] as $image) {
if (isset($image['picturetypeid']) && array_key_exists('data', $image)) {
$type = self::getPictureType((int)$image['picturetypeid']);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 111.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if (isset($id3['id3v2']['APIC'])) {
// Foreach in case they have more than one
foreach ($id3['id3v2']['APIC'] as $image) {
if (isset($image['picturetypeid']) && array_key_exists('data', $image)) {
$type = self::getPictureType((int)$image['picturetypeid']);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 111.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if (isset($id3['flac']['PICTURE'])) {
// Foreach in case they have more than one
foreach ($id3['flac']['PICTURE'] as $image) {
if (isset($image['typeid']) && array_key_exists('data', $image)) {
$type = self::getPictureType((int)$image['typeid']);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 111.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
The parameter $picture_type is not named in camelCase. Open
public static function getPictureType(int $picture_type): string
{
switch ($picture_type) {
case 1:
return '32x32 PNG Icon';
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The parameter $art_type is not named in camelCase. Open
private static function sortArtByPriority($data, $art_type): array
{
$priorities = ($art_type === 'artist')
? self::TAG_ARTIST_ART_PRIORITY
: self::TAG_ALBUM_ART_PRIORITY; // song and album art
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}