Sign upLogin

ampache/ampache

View on GitHub
Star
src/Module/Catalog/Update/UpdateSingleCatalogFolder.php

Summary

Maintainability
F
3 days
Test Coverage

Function update has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

    public function update(
        Interactor $interactor,
        string $catname,
        string $folderPath,
        bool $verificationMode,
Severity: Minor
Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Interactor $interactor,
        string $catname,
        string $folderPath,
        bool $verificationMode,
        bool $addMode,
Severity: Major
Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if ($media->artist && !$artist->has_db_info()) {
                                Catalog::gather_art_item('artist', $media->artist, true);
                            }
    Severity: Major
    Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (!$art->has_db_info()) {
                                Catalog::gather_art_item($art_type, $art_id, true);
                            }
      Severity: Major
      Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (!$art->has_db_info()) {
                                Catalog::gather_art_item($type, $file_id, true);
                            }
        Severity: Major
        Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php - About 45 mins to fix

          The method update() has an NPath complexity of 1886221. The configured NPath complexity threshold is 200.
          Open

              public function update(
        Interactor $interactor,
        string $catname,
        string $folderPath,
        bool $verificationMode,
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
    function bar() {
        // lots of complicated code
    }
}

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method update() has 151 lines of code. Current threshold is set to 100. Avoid really long methods.
          Open

              public function update(
        Interactor $interactor,
        string $catname,
        string $folderPath,
        bool $verificationMode,
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phpmd

          The method update() has a Cyclomatic Complexity of 37. The configured cyclomatic complexity threshold is 10.
          Open

              public function update(
        Interactor $interactor,
        string $catname,
        string $folderPath,
        bool $verificationMode,
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Refactor this function to reduce its Cognitive Complexity from 91 to the 15 allowed.
          Open

              public function update(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by sonar-php

          Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

          See

          Call to method info from undeclared class \Ahc\Cli\IO\Interactor
          Open

                              $interactor->info(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method info from undeclared class \Ahc\Cli\IO\Interactor
          Open

                          $interactor->info(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Possibly zero references to use statement for classlike/namespace Catalog_local (\Ampache\Module\Catalog\Catalog_local)
          Open

          use Ampache\Module\Catalog\Catalog_local;
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to instance property album from undeclared class \Ampache\Repository\Model\Song
          Open

                                      $art_id   = ($gather_song_art) ? $file_id : $media->album;
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method gather_art_item from undeclared class \Ampache\Repository\Model\Catalog
          Open

                                          Catalog::gather_art_item('artist', $media->artist, true);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method update_table_counts from undeclared class \Ampache\Repository\Model\Album
          Open

                              Album::update_table_counts();
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to instance property artist from undeclared class \Ampache\Repository\Model\Song
          Open

                                          Catalog::gather_art_item('artist', $media->artist, true);
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method gather_art_item from undeclared class \Ampache\Repository\Model\Catalog
          Open

                                          Catalog::gather_art_item($type, $file_id, true);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method clean_empty_albums from undeclared class \Ampache\Repository\Model\Catalog
          Open

                              Catalog::clean_empty_albums();
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method info from undeclared class \Ahc\Cli\IO\Interactor
          Open

                  $interactor->info(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method update_media_from_tags from undeclared class \Ampache\Repository\Model\Catalog
          Open

                                  Catalog::update_media_from_tags($media);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to instance property album from undeclared class \Ampache\Repository\Model\Song
          Open

                                      $art      = ($gather_song_art) ? new Art($file_id, $type) : new Art($media->album, $type);
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method read from undeclared class \Ampache\Module\System\Dba
          Open

                  $db_results = Dba::read($sql, array($catname));
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method create_from_id from undeclared class \Ampache\Repository\Model\Catalog
          Open

                      $catalog = Catalog::create_from_id($row['id']);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method get_ids_from_folder from undeclared class \Ampache\Repository\Model\Catalog
          Open

                              $file_ids  = Catalog::get_ids_from_folder($folderPath, $type);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method get_ids_from_folder from undeclared class \Ampache\Repository\Model\Catalog
          Open

                              $file_ids  = Catalog::get_ids_from_folder($folderPath, $type);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method get_ids_from_folder from undeclared class \Ampache\Repository\Model\Catalog
          Open

                              $file_ids  = Catalog::get_ids_from_folder($folderPath, $type);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method gather_art_item from undeclared class \Ampache\Repository\Model\Catalog
          Open

                                          Catalog::gather_art_item($art_type, $art_id, true);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Parameter $interactor has undeclared type \Ahc\Cli\IO\Interactor
          Open

              public function update(
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method error from undeclared class \Ahc\Cli\IO\Interactor
          Open

                          $interactor->error(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to constant class from undeclared class \Ampache\Repository\Model\Video
          Open

                              $className = Video::class;
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to instance property artist from undeclared class \Ampache\Repository\Model\Song
          Open

                                      if ($media->artist && !$artist->has_db_info()) {
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to constant class from undeclared class \Ampache\Repository\Model\Song
          Open

                              $className = Song::class;
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method update_album_artist from undeclared class \Ampache\Repository\Model\Album
          Open

                              Album::update_album_artist();
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method garbage_collect_filters from undeclared class \Ampache\Repository\Model\Catalog
          Open

                          Catalog::garbage_collect_filters();
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to constant class from undeclared class \Ampache\Repository\Model\Podcast_Episode
          Open

                              $className = Podcast_Episode::class;
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Reference to instance property artist from undeclared class \Ampache\Repository\Model\Song
          Open

                                      $artist   = new Art($media->artist, $type);
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method info from undeclared class \Ahc\Cli\IO\Interactor
          Open

                              $interactor->info(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method error from undeclared class \Ahc\Cli\IO\Interactor
          Open

                          $interactor->error(
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method __construct from undeclared class \Ampache\Repository\Model\Song
          Open

                                      $media    = new Song($file_id);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method update_catalog_map from undeclared class \Ampache\Repository\Model\Catalog
          Open

                          Catalog::update_catalog_map($catalog->gather_types);
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method fetch_assoc from undeclared class \Ampache\Module\System\Dba
          Open

                  while ($row = Dba::fetch_assoc($db_results)) {
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method update_table_counts from undeclared class \Ampache\Repository\Model\Artist
          Open

                              Artist::update_table_counts();
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Call to method garbage_collect_mapping from undeclared class \Ampache\Repository\Model\Catalog
          Open

                          Catalog::garbage_collect_mapping();
          Severity: Critical
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phan

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if ($searchArtMode == 1 && $file_id) {
                        // Look for media art after adding new files
                        $gather_song_art = (AmpConfig::get('gather_song_art', false));
                        if ($type == 'song') {
                            $media    = new Song($file_id);
          Severity: Major
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php and 1 other location - About 1 day to fix
          src/Module/Catalog/Update/UpdateSingleCatalogFile.php on lines 139..161

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 259.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      switch ($catalog->gather_types) {
                case 'podcast':
                    $type      = 'podcast_episode';
                    $file_ids  = Catalog::get_ids_from_folder($folderPath, $type);
                    $className = Podcast_Episode::class;
          Severity: Major
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php and 2 other locations - About 2 hrs to fix
          src/Module/Api/Method/CatalogFolderMethod.php on lines 105..125
          src/Repository/Model/Catalog.php on lines 4016..4036

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 137.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Expected 0 spaces after opening bracket; newline found
          Open

                          if (
          Severity: Minor
          Found in src/Module/Catalog/Update/UpdateSingleCatalogFolder.php by phpcodesniffer

          There are no issues that match your filters.

          Category
          Status