ampache/ampache

View on GitHub
src/Module/Util/UiInterface.php

Summary

Maintainability
A
45 mins
Test Coverage

Method showConfirmation has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $title,
        $text,
        $next_url,
        $cancel = 0,
        $form_name = 'confirmation',
Severity: Minor
Found in src/Module/Util/UiInterface.php - About 45 mins to fix

    The parameter $next_url is not named in camelCase.
    Open

        public function showContinue(
            string $title,
            string $text,
            string $next_url
        ): void;
    Severity: Minor
    Found in src/Module/Util/UiInterface.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
        public function doSomething($user_name) {
        }
    }

    Source

    The parameter $next_url is not named in camelCase.
    Open

        public function showConfirmation(
            $title,
            $text,
            $next_url,
            $cancel = 0,
    Severity: Minor
    Found in src/Module/Util/UiInterface.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
        public function doSomething($user_name) {
        }
    }

    Source

    The parameter $form_name is not named in camelCase.
    Open

        public function showConfirmation(
            $title,
            $text,
            $next_url,
            $cancel = 0,
    Severity: Minor
    Found in src/Module/Util/UiInterface.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
        public function doSomething($user_name) {
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status