ampache/ampache

View on GitHub
src/Module/Util/VaInfo.php

Summary

Maintainability
F
1 wk
Test Coverage

File VaInfo.php has 1623 lines of code (exceeds 500 allowed). Consider refactoring.
Open

<?php

declare(strict_types=0);

/**
Severity: Major
Found in src/Module/Util/VaInfo.php - About 3 days to fix

    Function _cleanup_id3v2 has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
    Open

        private function _cleanup_id3v2($tags): array
        {
            $parsed = array();
    
            foreach ($tags as $tag => $data) {
    Severity: Minor
    Found in src/Module/Util/VaInfo.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _parse_filename has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
    Open

        private function _parse_filename($filepath): array
        {
            $origin  = $filepath;
            $results = array();
            $file    = pathinfo($filepath, PATHINFO_FILENAME);
    Severity: Minor
    Found in src/Module/Util/VaInfo.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _cleanup_vorbiscomment has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

        private function _cleanup_vorbiscomment($tags): array
        {
            $parsed = array();
    
            foreach ($tags as $tag => $data) {
    Severity: Minor
    Found in src/Module/Util/VaInfo.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _cleanup_asf has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

        private function _cleanup_asf($tags): array
        {
            $parsed = array();
            foreach ($tags as $tagname => $data) {
                //$this->logger->debug('asf tag: ' . strtolower($tagname) . ' value: ' . print_r($data ?? '', true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
    Severity: Minor
    Found in src/Module/Util/VaInfo.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    VaInfo has 41 functions (exceeds 20 allowed). Consider refactoring.
    Open

    final class VaInfo implements VaInfoInterface
    {
        private const DEFAULT_INFO = array(
            'albumartist' => null,
            'album' => null,
    Severity: Minor
    Found in src/Module/Util/VaInfo.php - About 5 hrs to fix

      Function _cleanup_quicktime has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _cleanup_quicktime($tags): array
          {
              $parsed = array();
      
              foreach ($tags as $tag => $data) {
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct(
              UserRepositoryInterface $userRepository,
              ConfigContainerInterface $configContainer,
              LoggerInterface $logger,
              $file,
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class VaInfo has an overall complexity of 593 which is very high. The configured complexity threshold is 50.
      Open

      final class VaInfo implements VaInfoInterface
      {
          private const DEFAULT_INFO = array(
              'albumartist' => null,
              'album' => null,
      Severity: Minor
      Found in src/Module/Util/VaInfo.php by phpmd

      The class VaInfo has 12 public methods. Consider refactoring VaInfo to keep number of public methods under 10.
      Open

      final class VaInfo implements VaInfoInterface
      {
          private const DEFAULT_INFO = array(
              'albumartist' => null,
              'album' => null,
      Severity: Minor
      Found in src/Module/Util/VaInfo.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class VaInfo has 33 non-getter- and setter-methods. Consider refactoring VaInfo to keep number of methods under 25.
      Open

      final class VaInfo implements VaInfoInterface
      {
          private const DEFAULT_INFO = array(
              'albumartist' => null,
              'album' => null,
      Severity: Minor
      Found in src/Module/Util/VaInfo.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      Function _detect_encoding has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function _detect_encoding($tags, $mb_order): string
          {
              if (!function_exists('mb_detect_encoding')) {
                  return 'ISO-8859-1';
              }
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _parse_general has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _parse_general($tags): array
          {
              //$this->logger->debug('_parse_general: ' . print_r($tags, true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
              $parsed = array();
              if ((in_array('movie', $this->gatherTypes)) || (in_array('tvshow', $this->gatherTypes))) {
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _cleanup_generic has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _cleanup_generic($tags): array
          {
              $parsed = array();
              foreach ($tags as $tagname => $data) {
                  //$this->logger->debug('generic tag: ' . strtolower($tagname) . ' value: ' . print_r($data ?? '', true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function write_id3 has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function write_id3($tagData): void
          {
              $TaggingFormat = 'UTF-8';
              $tagWriter     = new getid3_writetags();
              $extension     = pathinfo($this->filename, PATHINFO_EXTENSION);
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_tags has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _get_tags(): array
          {
              $results = array();
              //$this->logger->debug('RAW TAGS ' . print_r($this->_raw, true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
              // The tags can come in many different shapes and colors depending on the encoding.
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function clean_tag_info has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function clean_tag_info($results, $keys, $filename = null): array
          {
              $info         = self::DEFAULT_INFO;
              $info['file'] = $filename;
      
      
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class VaInfo has 19 fields. Consider redesigning VaInfo to keep the number of fields under 15.
      Open

      final class VaInfo implements VaInfoInterface
      {
          private const DEFAULT_INFO = array(
              'albumartist' => null,
              'album' => null,
      Severity: Minor
      Found in src/Module/Util/VaInfo.php by phpmd

      TooManyFields

      Since: 0.1

      Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

      Example

      class Person {
         protected $one;
         private $two;
         private $three;
         [... many more fields ...]
      }

      Source https://phpmd.org/rules/codesize.html#toomanyfields

      Function parseGenres has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseGenres($data)
          {
              //debug_event(__CLASS__, "parseGenres: " . print_r($data, true), 5);
              $result = null;
              if (is_array($data)) {
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseArtists has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseArtists($data): array
          {
              //debug_event(__CLASS__, "parseArtists: " . print_r($data, true), 5);
              $result = null;
              if (is_array($data)) {
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_plugin_tags has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function _get_plugin_tags(): void
          {
              $tag_order    = $this->get_metadata_order();
              $plugin_names = Plugin::get_plugins('get_metadata');
              /** @var User $user */
      Severity: Minor
      Found in src/Module/Util/VaInfo.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              UserRepositoryInterface $userRepository,
              ConfigContainerInterface $configContainer,
              LoggerInterface $logger,
              $file,
              $gatherTypes = array(),
      Severity: Major
      Found in src/Module/Util/VaInfo.php - About 1 hr to fix

        Function get_tag_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function get_tag_type($results, $configKey = 'metadata_order'): array
            {
                $tagorderMap = [
                    'metadata_order' => static::getConfigContainer()->get(ConfigurationKeyEnum::METADATA_ORDER),
                    'metadata_order_video' => static::getConfigContainer()->get(ConfigurationKeyEnum::METADATA_ORDER_VIDEO),
        Severity: Minor
        Found in src/Module/Util/VaInfo.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parse_pattern has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function parse_pattern($filepath, $dirPattern, $filePattern): array
            {
                $logger          = static::getLogger();
                $results         = array();
                $slash_type_preg = DIRECTORY_SEPARATOR;
        Severity: Minor
        Found in src/Module/Util/VaInfo.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _get_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function _get_type(): ?string
            {
                // There are a few places that the file type can come from, in the end we trust the encoding type.
                if (array_key_exists('video', $this->_raw) && array_key_exists('dataformat', $this->_raw['video'])) {
                    return $this->_clean_type($this->_raw['video']['dataformat']);
        Severity: Minor
        Found in src/Module/Util/VaInfo.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function gather_tags has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function gather_tags(): void
            {
                // If this is broken, don't waste time figuring it out a second time, just return their rotting carcass of a media file.
                if ($this->_broken) {
                    $this->tags = $this->set_broken();
        Severity: Minor
        Found in src/Module/Util/VaInfo.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return $type;
        Severity: Major
        Found in src/Module/Util/VaInfo.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return 'ape';
          Severity: Major
          Found in src/Module/Util/VaInfo.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $type;
            Severity: Major
            Found in src/Module/Util/VaInfo.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return null;
              Severity: Major
              Found in src/Module/Util/VaInfo.php - About 30 mins to fix

                Function prepare_metadata_for_writing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function prepare_metadata_for_writing($frames): array
                    {
                        $ndata = array();
                        foreach ($frames as $key => $text) {
                            switch ($key) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                The method _cleanup_id3v2() has 204 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    private function _cleanup_id3v2($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method _cleanup_quicktime() has 106 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    private function _cleanup_quicktime($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method _cleanup_id3v2() has an NPath complexity of 35728. The configured NPath complexity threshold is 200.
                Open

                    private function _cleanup_id3v2($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _cleanup_vorbiscomment() has an NPath complexity of 765. The configured NPath complexity threshold is 200.
                Open

                    private function _cleanup_vorbiscomment($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _cleanup_vorbiscomment() has 139 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    private function _cleanup_vorbiscomment($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method __construct has 10 parameters. Consider reducing the number of parameters to less than 10.
                Open

                    public function __construct(
                        UserRepositoryInterface $userRepository,
                        ConfigContainerInterface $configContainer,
                        LoggerInterface $logger,
                        $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method _parse_general() has an NPath complexity of 3564. The configured NPath complexity threshold is 200.
                Open

                    private function _parse_general($tags): array
                    {
                        //$this->logger->debug('_parse_general: ' . print_r($tags, true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                        $parsed = array();
                        if ((in_array('movie', $this->gatherTypes)) || (in_array('tvshow', $this->gatherTypes))) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method __construct() has 104 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    public function __construct(
                        UserRepositoryInterface $userRepository,
                        ConfigContainerInterface $configContainer,
                        LoggerInterface $logger,
                        $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method clean_tag_info() has 125 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    public static function clean_tag_info($results, $keys, $filename = null): array
                    {
                        $info         = self::DEFAULT_INFO;
                        $info['file'] = $filename;
                
                
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method _cleanup_asf() has 124 lines of code. Current threshold is set to 100. Avoid really long methods.
                Open

                    private function _cleanup_asf($tags): array
                    {
                        $parsed = array();
                        foreach ($tags as $tagname => $data) {
                            //$this->logger->debug('asf tag: ' . strtolower($tagname) . ' value: ' . print_r($data ?? '', true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The class VaInfo has 2147 lines of code. Current threshold is 1000. Avoid really long classes.
                Open

                final class VaInfo implements VaInfoInterface
                {
                    private const DEFAULT_INFO = array(
                        'albumartist' => null,
                        'album' => null,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                The method _parse_filename() has an NPath complexity of 776. The configured NPath complexity threshold is 200.
                Open

                    private function _parse_filename($filepath): array
                    {
                        $origin  = $filepath;
                        $results = array();
                        $file    = pathinfo($filepath, PATHINFO_FILENAME);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _cleanup_asf() has an NPath complexity of 480. The configured NPath complexity threshold is 200.
                Open

                    private function _cleanup_asf($tags): array
                    {
                        $parsed = array();
                        foreach ($tags as $tagname => $data) {
                            //$this->logger->debug('asf tag: ' . strtolower($tagname) . ' value: ' . print_r($data ?? '', true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method __construct() has an NPath complexity of 580. The configured NPath complexity threshold is 200.
                Open

                    public function __construct(
                        UserRepositoryInterface $userRepository,
                        ConfigContainerInterface $configContainer,
                        LoggerInterface $logger,
                        $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method clean_tag_info() has an NPath complexity of 9223372036854775807. The configured NPath complexity threshold is 200.
                Open

                    public static function clean_tag_info($results, $keys, $filename = null): array
                    {
                        $info         = self::DEFAULT_INFO;
                        $info['file'] = $filename;
                
                
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method _cleanup_id3v2() has a Cyclomatic Complexity of 65. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _cleanup_id3v2($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _cleanup_asf() has a Cyclomatic Complexity of 43. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _cleanup_asf($tags): array
                    {
                        $parsed = array();
                        foreach ($tags as $tagname => $data) {
                            //$this->logger->debug('asf tag: ' . strtolower($tagname) . ' value: ' . print_r($data ?? '', true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _cleanup_quicktime() has a Cyclomatic Complexity of 32. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _cleanup_quicktime($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method __construct() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
                Open

                    public function __construct(
                        UserRepositoryInterface $userRepository,
                        ConfigContainerInterface $configContainer,
                        LoggerInterface $logger,
                        $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _clean_type() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _clean_type($type): string
                    {
                        switch ($type) {
                            case 'mp2':
                            case 'mp3':
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _parse_filename() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _parse_filename($filepath): array
                    {
                        $origin  = $filepath;
                        $results = array();
                        $file    = pathinfo($filepath, PATHINFO_FILENAME);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _cleanup_generic() has a Cyclomatic Complexity of 27. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _cleanup_generic($tags): array
                    {
                        $parsed = array();
                        foreach ($tags as $tagname => $data) {
                            //$this->logger->debug('generic tag: ' . strtolower($tagname) . ' value: ' . print_r($data ?? '', true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method clean_tag_info() has a Cyclomatic Complexity of 151. The configured cyclomatic complexity threshold is 10.
                Open

                    public static function clean_tag_info($results, $keys, $filename = null): array
                    {
                        $info         = self::DEFAULT_INFO;
                        $info['file'] = $filename;
                
                
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _parse_general() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _parse_general($tags): array
                    {
                        //$this->logger->debug('_parse_general: ' . print_r($tags, true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                        $parsed = array();
                        if ((in_array('movie', $this->gatherTypes)) || (in_array('tvshow', $this->gatherTypes))) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method write_id3() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                Open

                    public function write_id3($tagData): void
                    {
                        $TaggingFormat = 'UTF-8';
                        $tagWriter     = new getid3_writetags();
                        $extension     = pathinfo($this->filename, PATHINFO_EXTENSION);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _detect_encoding() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                Open

                    private static function _detect_encoding($tags, $mb_order): string
                    {
                        if (!function_exists('mb_detect_encoding')) {
                            return 'ISO-8859-1';
                        }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _cleanup_vorbiscomment() has a Cyclomatic Complexity of 50. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _cleanup_vorbiscomment($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method _get_tags() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                Open

                    private function _get_tags(): array
                    {
                        $results = array();
                        //$this->logger->debug('RAW TAGS ' . print_r($this->_raw, true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                        // The tags can come in many different shapes and colors depending on the encoding.
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                $mb_order = 'auto';
                            }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                $tags = array();
                                foreach ($test_tags as $tag) {
                                    if (array_key_exists('id3v1', $this->_raw) && array_key_exists($tag, $this->_raw['id3v1']) && $value = $this->_raw['id3v1'][$tag]) {
                                        $tags[$tag] = $value;
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid assigning values to variables in if clauses and the like (line '235', column '115').
                Open

                    public function __construct(
                        UserRepositoryInterface $userRepository,
                        ConfigContainerInterface $configContainer,
                        LoggerInterface $logger,
                        $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($foo = 'bar') { // possible typo
                            // ...
                        }
                        if ($baz = 0) { // always false
                            // ...
                        }
                    }
                }

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                Avoid assigning values to variables in if clauses and the like (line '1529', column '21').
                Open

                    private function _cleanup_id3v2($tags): array
                    {
                        $parsed = array();
                
                        foreach ($tags as $tag => $data) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($foo = 'bar') { // possible typo
                            // ...
                        }
                        if ($baz = 0) { // always false
                            // ...
                        }
                    }
                }

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                The method _parse_general uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
                            $parsed['title'] = urldecode($this->_pathinfo['filename']);
                        }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_filename uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                    } else {
                                        if (preg_match("~[\_\-\.\s](\d)(\d\d)[\_\-\.\s]*~", $file, $seasonEpisode)) {
                                            $temp      = preg_split("~[\.\s\-\_](\d)(\d\d)[\.\s\-\_]~", $file);
                                            $season[0] = $seasonEpisode[1];
                                            if (preg_match("~[\_\-\.\s](\d)(\d\d)[\_\-\.\s]~", $file, $seasonEpisode)) {
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method write_id3 uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                $command = 'metaflac --remove --block-type=PICTURE ' . escapeshellarg($this->filename);
                            }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_general uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
                            $this->logger->critical("UNABLE TO READ 'playtime_seconds'. This is probably a bad file " . $parsed['title'], [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                            $parsed['time'] = 0;
                        }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _detect_encoding uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
                            $enc = mb_detect_encoding($tags, $mb_order, true);
                            if ($enc !== false) {
                                $encodings[$enc] = 1;
                            }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_filename uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    if (preg_match("~[S|s]eason[\_\-\.\s](\d+)[\.\-\s\_]?\s?[e|E]pisode[\s\-\.\_]?(\d+)[\.\s\-\_]?~", $file, $seasonEpisode)) {
                                        $temp = preg_split(
                                            "~[\.\s\-\_][S|s]eason[\s\-\.\_](\d+)[\.\s\-\_]?\s?[e|E]pisode[\s\-\.\_](\d+)([\s\-\.\_])*~",
                                            $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_filename uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                            } else {
                                                // match pattern like 10.episode name.mp4
                                                if (preg_match("~^(\d\d)[\_\-\.\s]?(.*)~", $file, $matches)) {
                                                    $results['tvshow_episode'] = $matches[1];
                                                    $results['original_name']  = $this->formatVideoName($matches[2]);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid assigning values to variables in if clauses and the like (line '248', column '115').
                Open

                    public function __construct(
                        UserRepositoryInterface $userRepository,
                        ConfigContainerInterface $configContainer,
                        LoggerInterface $logger,
                        $file,
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($foo = 'bar') { // possible typo
                            // ...
                        }
                        if ($baz = 0) { // always false
                            // ...
                        }
                    }
                }

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
                            $this->_pathinfo = pathinfo(str_replace('%2F', '/', urlencode($this->filename)));
                        }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_filename uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                } else {
                                    // Or we assume each parent folder contains one missing information
                                    if (preg_match('/[\/\\\\]([^\/\\\\]*)[\/\\\\]Season (\d{1,2})[\/\\\\]((E|Ep|Episode)\s?(\d{1,2})[\/\\\\])?/i', $filepath, $matches)) {
                                        if ($matches != null) {
                                            $results['tvshow']        = $this->formatVideoName($matches[1]);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_filename uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                                                } else {
                                                    // Fallback to match any 3-digit Season/Episode that fails the standard pattern above.
                                                    preg_match("~(\d)(\d\d)[\_\-\.\s]?~", $file, $matches);
                                                    $results['tvshow_episode'] = $matches[2];
                                                }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _parse_filename uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                            } else {
                                if (preg_match("~[\_\-\.\s](\d{1,2})[xX](\d{1,2})~", $file, $seasonEpisode)) {
                                    $temp = preg_split("~[\.\_\s\-\_]\d+[xX]\d{2}[\.\s\-\_]*|$~", $file);
                                    preg_match("~\d+(?=[Xx])~", $file, $season);
                                    preg_match("~(?<=[Xx])\d+~", $file, $episode);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                The method _detect_encoding uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                Open

                        } else {
                            return 'ISO-8859-1';
                        }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                ElseExpression

                Since: 1.4.0

                An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($flag) {
                            // one branch
                        } else {
                            // another branch
                        }
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#elseexpression

                Avoid unused local variables such as '$commandError'.
                Open

                            $commandError = `$command`;
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                UnusedLocalVariable

                Since: 0.2

                Detects when a local variable is declared and/or assigned, but not used.

                Example

                class Foo {
                    public function doSomething()
                    {
                        $i = 5; // Unused
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                FIXME found
                Open

                        // FIXME: This looks ugly and probably wrong
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by fixme

                FIXME found
                Open

                                        // FIXME: shouldn't here $txxx['data'] be replaced by $id3v2['comments']['text'][$txxx['description']]
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by fixme

                TODO found
                Open

                     * //TODO: where did this go? param string $encodingId3v2
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by fixme

                FIXME found
                Open

                     * This is supposed to handle lyrics3. FIXME: does it?
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by fixme

                syntax error, unexpected 'UserRepositoryInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
                Open

                    private UserRepositoryInterface $userRepository;
                Severity: Critical
                Found in src/Module/Util/VaInfo.php by phan

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                case 'originaldate':
                                    $parsed['originaldate'] = strtotime(str_replace(" ", "", $data[0]));
                                    if (strlen($data['0']) > 4) {
                                        $data[0] = date('Y', $parsed['originaldate']);
                                    }
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 1 other location - About 1 hr to fix
                src/Module/Util/VaInfo.php on lines 1645..1651

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 108.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                case 'originaldate':
                                    $parsed['originaldate'] = strtotime(str_replace(" ", "", $data[0]));
                                    if (strlen($data['0']) > 4) {
                                        $data[0] = date('Y', $parsed['originaldate']);
                                    }
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 1 other location - About 1 hr to fix
                src/Module/Util/VaInfo.php on lines 1250..1256

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 108.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz_albumstatus':
                                    $parsed['release_status'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1731..1735
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz_albumtype':
                                    $parsed['release_type'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz album status':
                                    $parsed['release_status'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1731..1735
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz_albumtype':
                                    $parsed['release_type'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1731..1735
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz album type':
                                    $parsed['release_type'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1731..1735
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz_albumstatus':
                                    $parsed['release_status'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1731..1735
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz_albumstatus':
                                    $parsed['release_status'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1114..1118
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1731..1735

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                                case 'musicbrainz_albumtype':
                                    $parsed['release_type'] = (is_array($data) && count($data) > 1)
                                        ? implode(", ", $data)
                                        : implode(', ', array_diff(preg_split("/[^a-zA-Z0-9*]/", $data[0]), array('')));
                                    break;
                Severity: Major
                Found in src/Module/Util/VaInfo.php and 7 other locations - About 35 mins to fix
                src/Module/Util/VaInfo.php on lines 1119..1123
                src/Module/Util/VaInfo.php on lines 1234..1238
                src/Module/Util/VaInfo.php on lines 1240..1244
                src/Module/Util/VaInfo.php on lines 1615..1619
                src/Module/Util/VaInfo.php on lines 1620..1624
                src/Module/Util/VaInfo.php on lines 1731..1735
                src/Module/Util/VaInfo.php on lines 1736..1740

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid excessively long variable names like $enable_custom_metadata. Keep variable name length under 20.
                Open

                            $enable_custom_metadata = $this->configContainer->get(ConfigurationKeyEnum::ENABLE_CUSTOM_METADATA);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
                    protected $reallyLongIntName = -3; // VIOLATION - Field
                    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                        $otherReallyLongName = -5; // VIOLATION - Local
                        for ($interestingIntIndex = 0; // VIOLATION - For
                             $interestingIntIndex < 10;
                             $interestingIntIndex++ ) {
                        }
                    }
                }

                Source https://phpmd.org/rules/naming.html#longvariable

                Avoid excessively long variable names like $enable_custom_metadata. Keep variable name length under 20.
                Open

                            $enable_custom_metadata = $this->configContainer->get(ConfigurationKeyEnum::ENABLE_CUSTOM_METADATA);
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                LongVariable

                Since: 0.2

                Detects when a field, formal or local variable is declared with a long name.

                Example

                class Something {
                    protected $reallyLongIntName = -3; // VIOLATION - Field
                    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                        $otherReallyLongName = -5; // VIOLATION - Local
                        for ($interestingIntIndex = 0; // VIOLATION - For
                             $interestingIntIndex < 10;
                             $interestingIntIndex++ ) {
                        }
                    }
                }

                Source https://phpmd.org/rules/naming.html#longvariable

                The parameter $mb_order is not named in camelCase.
                Open

                    private static function _detect_encoding($tags, $mb_order): string
                    {
                        if (!function_exists('mb_detect_encoding')) {
                            return 'ISO-8859-1';
                        }
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
                    public function doSomething($user_name) {
                    }
                }

                Source

                Property name "$_file_pattern" should not be prefixed with an underscore to indicate visibility
                Open

                    protected $_file_pattern  = '';
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_pathinfo" should not be prefixed with an underscore to indicate visibility
                Open

                    private $_pathinfo;
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_raw" should not be prefixed with an underscore to indicate visibility
                Open

                    protected $_raw           = array();
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_get_type" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _get_type(): ?string
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_dir_pattern" should not be prefixed with an underscore to indicate visibility
                Open

                    protected $_dir_pattern   = '';
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_lyrics" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_lyrics($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_riff" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_riff($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_forcedSize" should not be prefixed with an underscore to indicate visibility
                Open

                    protected $_forcedSize    = 0;
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_detect_encoding" should not be prefixed with an underscore to indicate visibility
                Open

                    private static function _detect_encoding($tags, $mb_order): string
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_clean_type" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _clean_type($type): string
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_broken" should not be prefixed with an underscore to indicate visibility
                Open

                    private $_broken = false;
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_asf" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_asf($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_get_tags" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _get_tags(): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_generic" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_generic($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_id3v2" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_id3v2($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_vorbiscomment" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_vorbiscomment($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_get_plugin_tags" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _get_plugin_tags(): void
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_quicktime" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_quicktime($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_getID3" should not be prefixed with an underscore to indicate visibility
                Open

                    protected $_getID3        = null;
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Property name "$_file_encoding" should not be prefixed with an underscore to indicate visibility
                Open

                    protected $_file_encoding = '';
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_cleanup_id3v1" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _cleanup_id3v1($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_parse_general" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _parse_general($tags): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Method name "_parse_filename" should not be prefixed with an underscore to indicate visibility
                Open

                    private function _parse_filename($filepath): array
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                Expected 0 spaces after opening bracket; newline found
                Open

                                if (
                Severity: Minor
                Found in src/Module/Util/VaInfo.php by phpcodesniffer

                There are no issues that match your filters.

                Category
                Status