ampache/ampache

View on GitHub
src/Module/WebDav/WebDavFactory.php

Summary

Maintainability
A
0 mins
Test Coverage

syntax error, unexpected 'AuthenticationManagerInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private AuthenticationManagerInterface $authenticationManager;
Severity: Critical
Found in src/Module/WebDav/WebDavFactory.php by phan

Avoid excessively long variable names like $authenticationManager. Keep variable name length under 20.
Open

    private AuthenticationManagerInterface $authenticationManager;
Severity: Minor
Found in src/Module/WebDav/WebDavFactory.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $authenticationManager. Keep variable name length under 20.
Open

        AuthenticationManagerInterface $authenticationManager
Severity: Minor
Found in src/Module/WebDav/WebDavFactory.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The parameter $catalog_id is not named in camelCase.
Open

    public function createWebDavCatalog(int $catalog_id = 0): WebDavCatalog
    {
        return new WebDavCatalog($catalog_id);
    }
Severity: Minor
Found in src/Module/WebDav/WebDavFactory.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

There are no issues that match your filters.

Category
Status