Sign upLogin

ampache/ampache

View on GitHub
Star
src/Plugin/AmpacheLastfm.php

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in src/Plugin/AmpacheLastfm.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in src/Plugin/AmpacheLastfm.php - About 30 mins to fix

      The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            debug_event('lastfm.plugin', 'No session key, not scrobbling (need to grant Ampache to last.fm)', 4);

            return false;
        }
      Severity: Minor
      Found in src/Plugin/AmpacheLastfm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
      Open

          public string $name        = 'Last.FM';
      Severity: Critical
      Found in src/Plugin/AmpacheLastfm.php by phan

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function install(): bool
    {
        if (!Preference::insert('lastfm_challenge', T_('Last.FM Submit Challenge'), '', 25, 'string', 'internal', $this->name)) {
            return false;
        }
      Severity: Major
      Found in src/Plugin/AmpacheLastfm.php and 7 other locations - About 1 hr to fix
      src/Plugin/AmpacheBitly.php on lines 60..71
      src/Plugin/AmpacheDiscogs.php on lines 61..71
      src/Plugin/AmpacheHeadphones.php on lines 60..70
      src/Plugin/AmpachePaypal.php on lines 60..70
      src/Plugin/AmpacheTheaudiodb.php on lines 68..79
      src/Plugin/Ampachelibrefm.php on lines 67..77
      src/Plugin/Ampachelistenbrainz.php on lines 64..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function uninstall(): bool
    {
        return (
            Preference::delete('lastfm_challenge') &&
            Preference::delete('lastfm_grant_link') &&
      Severity: Minor
      Found in src/Plugin/AmpacheLastfm.php and 1 other location - About 30 mins to fix
      src/Plugin/Ampachelibrefm.php on lines 83..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status