src/Plugin/AmpacheLibravatar.php
get_avatar_url accesses the super-global variable $_SERVER. Open
Open
public function get_avatar_url($user, $size = 80): string
{
$url = "";
if (!empty($user->email)) {
// Federated Servers are not supported here without libravatar.org. Should query DNS server first.
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
The method get_avatar_url uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$url = "http://cdn.libravatar.org";
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open
Open
public string $name = 'Libravatar';
- Exclude checks