Sign upLogin

ampache/ampache

View on GitHub
Star
src/Repository/AccessRepository.php

Summary

Maintainability
A
1 hr
Test Coverage

Method update has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        int $accessId,
        string $startIp,
        string $endIp,
        string $name,
        int $userId,
Severity: Major
Found in src/Repository/AccessRepository.php - About 50 mins to fix

    Method create has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $startIp,
        string $endIp,
        string $name,
        int $userId,
        int $level,
    Severity: Minor
    Found in src/Repository/AccessRepository.php - About 45 mins to fix

      The method findByIp uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $sql .= sprintf(' AND `user` = %d', User::INTERNAL_SYSTEM_USER_ID);
        }
      Severity: Minor
      Found in src/Repository/AccessRepository.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      syntax error, unexpected 'DatabaseConnectionInterface' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
      Open

          private DatabaseConnectionInterface $connection;
      Severity: Critical
      Found in src/Repository/AccessRepository.php by phan

      Expected 0 spaces after opening bracket; newline found
      Open

              if (
      Severity: Minor
      Found in src/Repository/AccessRepository.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status