ampache/ampache

View on GitHub
src/Repository/Model/Album.php

Summary

Maintainability
F
5 days
Test Coverage

File Album.php has 866 lines of code (exceeds 500 allowed). Consider refactoring.
Open

<?php

declare(strict_types=0);

/**
Severity: Major
Found in src/Repository/Model/Album.php - About 1 day to fix

    Album has 48 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Album extends database_object implements library_item, CatalogItemInterface
    {
        protected const DB_TABLENAME = 'album';
    
        /* Variables from DB */
    Severity: Minor
    Found in src/Repository/Model/Album.php - About 6 hrs to fix

      Function update has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
      Open

          public function update(array $data): int
          {
              //debug_event(self::class, "update: " . print_r($data, true), 4);
              $name           = $data['name'] ?? $this->name;
              $album_artist   = (isset($data['album_artist']) && (int)$data['album_artist'] > 0) ? (int)$data['album_artist'] : null;
      Severity: Minor
      Found in src/Repository/Model/Album.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function check has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
          {
              $trimmed        = Catalog::trim_prefix(trim((string) $name));
              $name           = $trimmed['string'];
              $prefix         = $trimmed['prefix'];
      Severity: Minor
      Found in src/Repository/Model/Album.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class Album has an overall complexity of 184 which is very high. The configured complexity threshold is 50.
      Open

      class Album extends database_object implements library_item, CatalogItemInterface
      {
          protected const DB_TABLENAME = 'album';
      
          /* Variables from DB */
      Severity: Minor
      Found in src/Repository/Model/Album.php by phpmd

      The class Album has 13 public methods. Consider refactoring Album to keep number of public methods under 10.
      Open

      class Album extends database_object implements library_item, CatalogItemInterface
      {
          protected const DB_TABLENAME = 'album';
      
          /* Variables from DB */
      Severity: Minor
      Found in src/Repository/Model/Album.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      Function get_f_artist_link has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_f_artist_link(): ?string
          {
              // don't do anything if it's formatted
              if (!isset($this->f_artist_link)) {
                  if ($this->album_artist === 0) {
      Severity: Minor
      Found in src/Repository/Model/Album.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 13 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
      Severity: Major
      Found in src/Repository/Model/Album.php - About 1 hr to fix

        The class Album has 44 fields. Consider redesigning Album to keep the number of fields under 15.
        Open

        class Album extends database_object implements library_item, CatalogItemInterface
        {
            protected const DB_TABLENAME = 'album';
        
            /* Variables from DB */
        Severity: Minor
        Found in src/Repository/Model/Album.php by phpmd

        TooManyFields

        Since: 0.1

        Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

        Example

        class Person {
           protected $one;
           private $two;
           private $three;
           [... many more fields ...]
        }

        Source https://phpmd.org/rules/codesize.html#toomanyfields

        Function get_fullname has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function get_fullname($simple = false, $force_year = false): string
            {
                // return the basic name without all the wild formatting
                if ($simple) {
                    return trim(trim($this->prefix ?? '') . ' ' . trim($this->name ?? ''));
        Severity: Minor
        Found in src/Repository/Model/Album.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The class Album has 81 public methods and attributes. Consider reducing the number of public items to less than 45.
        Open

        class Album extends database_object implements library_item, CatalogItemInterface
        {
            protected const DB_TABLENAME = 'album';
        
            /* Variables from DB */
        Severity: Minor
        Found in src/Repository/Model/Album.php by phpmd

        ExcessivePublicCount

        Since: 0.1

        A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.

        Example

        public class Foo {
            public $value;
            public $something;
            public $var;
            // [... more more public attributes ...]
        
            public function doWork() {}
            public function doMoreWork() {}
            public function doWorkAgain() {}
            // [... more more public methods ...]
        }

        Source https://phpmd.org/rules/codesize.html#excessivepubliccount

        Function format has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function format($details = true, $limit_threshold = ''): void
            {
                if ($this->isNew()) {
                    return;
                }
        Severity: Minor
        Found in src/Repository/Model/Album.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return (int)$album_id;
        Severity: Major
        Found in src/Repository/Model/Album.php - About 30 mins to fix

          Function display_art has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function display_art($thumb = 2, $force = false): void
              {
                  $album_id = null;
                  $type     = null;
          
          
          Severity: Minor
          Found in src/Repository/Model/Album.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method check() has an NPath complexity of 125829120. The configured NPath complexity threshold is 200.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method update() has 158 lines of code. Current threshold is set to 100. Avoid really long methods.
          Open

              public function update(array $data): int
              {
                  //debug_event(self::class, "update: " . print_r($data, true), 4);
                  $name           = $data['name'] ?? $this->name;
                  $album_artist   = (isset($data['album_artist']) && (int)$data['album_artist'] > 0) ? (int)$data['album_artist'] : null;
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          The class Album has 1248 lines of code. Current threshold is 1000. Avoid really long classes.
          Open

          class Album extends database_object implements library_item, CatalogItemInterface
          {
              protected const DB_TABLENAME = 'album';
          
              /* Variables from DB */
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          The method check has 13 parameters. Consider reducing the number of parameters to less than 10.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          The method update() has an NPath complexity of 5984928. The configured NPath complexity threshold is 200.
          Open

              public function update(array $data): int
              {
                  //debug_event(self::class, "update: " . print_r($data, true), 4);
                  $name           = $data['name'] ?? $this->name;
                  $album_artist   = (isset($data['album_artist']) && (int)$data['album_artist'] > 0) ? (int)$data['album_artist'] : null;
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method get_fullname() has an NPath complexity of 224. The configured NPath complexity threshold is 200.
          Open

              public function get_fullname($simple = false, $force_year = false): string
              {
                  // return the basic name without all the wild formatting
                  if ($simple) {
                      return trim(trim($this->prefix ?? '') . ' ' . trim($this->name ?? ''));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method check() has 155 lines of code. Current threshold is set to 100. Avoid really long methods.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          The method get_fullname() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
          Open

              public function get_fullname($simple = false, $force_year = false): string
              {
                  // return the basic name without all the wild formatting
                  if ($simple) {
                      return trim(trim($this->prefix ?? '') . ' ' . trim($this->name ?? ''));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method check() has a Cyclomatic Complexity of 30. The configured cyclomatic complexity threshold is 10.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method update() has a Cyclomatic Complexity of 32. The configured cyclomatic complexity threshold is 10.
          Open

              public function update(array $data): int
              {
                  //debug_event(self::class, "update: " . print_r($data, true), 4);
                  $name           = $data['name'] ?? $this->name;
                  $album_artist   = (isset($data['album_artist']) && (int)$data['album_artist'] > 0) ? (int)$data['album_artist'] : null;
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The class Album has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.
          Open

          class Album extends database_object implements library_item, CatalogItemInterface
          {
              protected const DB_TABLENAME = 'album';
          
              /* Variables from DB */
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
              /**
               * @var \foo\bar\X
               */
              private $x = null;
          
              /**
               * @var \foo\bar\Y
               */
              private $y = null;
          
              /**
               * @var \foo\bar\Z
               */
              private $z = null;
          
              public function setFoo(\Foo $foo) {}
              public function setBar(\Bar $bar) {}
              public function setBaz(\Baz $baz) {}
          
              /**
               * @return \SplObjectStorage
               * @throws \OutOfRangeException
               * @throws \InvalidArgumentException
               * @throws \ErrorException
               */
              public function process(\Iterator $it) {}
          
              // ...
          }

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          The method get_artist_fullname uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                      } else {
                          $this->artist_prefix = '';
                          $this->artist_name   = '';
                          $this->f_artist_name = '';
                      }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method get_f_artist_link uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                      } else {
                          $this->f_artist_link = '';
                      }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`album_artist` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid assigning values to variables in if clauses and the like (line '359', column '13').
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`release_status` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`mbid` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method format uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $web_path          = AmpConfig::get('web_path');
                      $year              = $this->year;
                      $this->f_year_link = "<a href=\"$web_path/search.php?type=album&action=search&limit=0rule_1=year&rule_1_operator=2&rule_1_input=" . $year . "\">" . $year . "</a>";
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method update_field uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql = "UPDATE `album` SET `" . $field . "` = ? WHERE `id` = ?";
                      Dba::write($sql, array($value, $album_id));
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`release_type` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method get_f_artist_link uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                          } else {
                              $this->f_artist_link = '';
                          }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`catalog_number` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`original_year` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`mbid_group` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`version` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      // run updates on the single fields
                      if (!empty($name) && $name != $this->get_fullname()) {
                          $trimmed          = Catalog::trim_prefix(trim((string) $name));
                          $new_name         = $trimmed['string'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`prefix` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $sql .= 'AND `album`.`barcode` IS NULL ';
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid unused parameters such as '$limit_threshold'.
          Open

              public function format($details = true, $limit_threshold = ''): void
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
          Open

              public int $id = 0;
          Severity: Critical
          Found in src/Repository/Model/Album.php by phan

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function get_keywords(): array
              {
                  $keywords               = array();
                  $keywords['mb_albumid'] = array(
                      'important' => false,
          Severity: Major
          Found in src/Repository/Model/Album.php and 1 other location - About 6 hrs to fix
          src/Repository/Model/AlbumDisk.php on lines 248..278

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 218.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function add_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "add_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "INSERT IGNORE INTO `album_map` (`album_id`, `object_type`, `object_id`) VALUES (?, ?, ?);";
          Severity: Major
          Found in src/Repository/Model/Album.php and 1 other location - About 1 hr to fix
          src/Repository/Model/Album.php on lines 1084..1091

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static function remove_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "remove_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "DELETE FROM `album_map` WHERE `album_id` = ? AND `object_type` = ? AND `object_id` = ?;";
          Severity: Major
          Found in src/Repository/Model/Album.php and 1 other location - About 1 hr to fix
          src/Repository/Model/Album.php on lines 1072..1079

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          The parameter $release_type is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_type is not named in camelCase.
          Open

              public static function add_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "add_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "INSERT IGNORE INTO `album_map` (`album_id`, `object_type`, `object_id`) VALUES (?, ?, ?);";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              public static function update_album_count(int $album_id): void
              {
                  $params = array($album_id);
                  // album.time
                  $sql = "UPDATE `album`, (SELECT SUM(`song`.`time`) AS `time`, `song`.`album` FROM `song` WHERE `album` = ? GROUP BY `song`.`album`) AS `song` SET `album`.`time` = `song`.`time` WHERE `album`.`id` = `song`.`album` AND ((`album`.`time` != `song`.`time`) OR (`album`.`time` IS NULL AND `song`.`time` > 0));";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $filter_type is not named in camelCase.
          Open

              public function get_medias(?string $filter_type = null): array
              {
                  $medias = array();
                  if (!$filter_type || $filter_type === 'song') {
                      $songs = $this->getSongRepository()->getByAlbum($this->id);
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              public static function add_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "add_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "INSERT IGNORE INTO `album_map` (`album_id`, `object_type`, `object_id`) VALUES (?, ?, ?);";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_id is not named in camelCase.
          Open

              public static function add_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "add_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "INSERT IGNORE INTO `album_map` (`album_id`, `object_type`, `object_id`) VALUES (?, ?, ?);";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $force_year is not named in camelCase.
          Open

              public function get_fullname($simple = false, $force_year = false): string
              {
                  // return the basic name without all the wild formatting
                  if ($simple) {
                      return trim(trim($this->prefix ?? '') . ' ' . trim($this->name ?? ''));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $primary_id is not named in camelCase.
          Open

              public static function get_parent_array($album_id, $primary_id, $object_type = 'album'): array
              {
                  $results    = array();
                  $sql        = "SELECT DISTINCT `object_id` FROM `album_map` WHERE `object_type` = ? AND `album_id` = ?;";
                  $db_results = Dba::read($sql, array($object_type, $album_id));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              public static function remove_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "remove_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "DELETE FROM `album_map` WHERE `album_id` = ? AND `object_type` = ? AND `object_id` = ?;";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_id is not named in camelCase.
          Open

              public static function check_album_map(int $album_id, string $object_type, int $object_id): bool
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      // Remove the album_map if this was the last track
                      $sql = ($object_type == 'album')
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $catalog_id is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $mbid_group is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              public function __construct($album_id = 0)
              {
                  if (!$album_id) {
                      return;
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $original_year is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              private static function update_field($field, $value, $album_id): void
              {
                  if ($value === null) {
                      $sql = "UPDATE `album` SET `" . $field . "` = NULL WHERE `id` = ?";
                      Dba::write($sql, array($album_id));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_id is not named in camelCase.
          Open

              public static function remove_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "remove_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "DELETE FROM `album_map` WHERE `album_id` = ? AND `object_type` = ? AND `object_id` = ?;";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

              public int $id = 0;
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          The parameter $release_status is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_type is not named in camelCase.
          Open

              public static function get_parent_array($album_id, $primary_id, $object_type = 'album'): array
              {
                  $results    = array();
                  $sql        = "SELECT DISTINCT `object_id` FROM `album_map` WHERE `object_type` = ? AND `album_id` = ?;";
                  $db_results = Dba::read($sql, array($object_type, $album_id));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $limit_threshold is not named in camelCase.
          Open

              public function format($details = true, $limit_threshold = ''): void
              {
                  if ($this->isNew()) {
                      return;
                  }
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_type is not named in camelCase.
          Open

              public static function check_album_map(int $album_id, string $object_type, int $object_id): bool
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      // Remove the album_map if this was the last track
                      $sql = ($object_type == 'album')
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $catalog_number is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $object_type is not named in camelCase.
          Open

              public static function remove_album_map(int $album_id, string $object_type, int $object_id): void
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      debug_event(__CLASS__, "remove_album_map album_id {" . $album_id . "} " . $object_type . "_artist {" . $object_id . "}", 5);
                      $sql = "DELETE FROM `album_map` WHERE `album_id` = ? AND `object_type` = ? AND `object_id` = ?;";
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              public static function check_album_map(int $album_id, string $object_type, int $object_id): bool
              {
                  if ((int)$album_id > 0 && (int)$object_id > 0) {
                      // Remove the album_map if this was the last track
                      $sql = ($object_type == 'album')
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_id is not named in camelCase.
          Open

              public static function get_parent_array($album_id, $primary_id, $object_type = 'album'): array
              {
                  $results    = array();
                  $sql        = "SELECT DISTINCT `object_id` FROM `album_map` WHERE `object_type` = ? AND `album_id` = ?;";
                  $db_results = Dba::read($sql, array($object_type, $album_id));
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          The parameter $album_artist is not named in camelCase.
          Open

              public static function check($catalog_id, $name, $year = 0, $mbid = null, $mbid_group = null, $album_artist = null, $release_type = null, $release_status = null, $original_year = null, $barcode = null, $catalog_number = null, $version = null, $readonly = false): int
              {
                  $trimmed        = Catalog::trim_prefix(trim((string) $name));
                  $name           = $trimmed['string'];
                  $prefix         = $trimmed['prefix'];
          Severity: Minor
          Found in src/Repository/Model/Album.php by phpmd

          CamelCaseParameterName

          Since: 0.2

          It is considered best practice to use the camelCase notation to name parameters.

          Example

          class ClassName {
              public function doSomething($user_name) {
              }
          }

          Source

          Method name "_get_extra_info" should not be prefixed with an underscore to indicate visibility
          Open

              private function _get_extra_info(): array

          Property name "$_fake" should not be prefixed with an underscore to indicate visibility
          Open

              public $_fake;

          Property name "$_songs" should not be prefixed with an underscore to indicate visibility
          Open

              public $_songs = array();

          Property name "$_mapcache" should not be prefixed with an underscore to indicate visibility
          Open

              private static $_mapcache = array();

          There are no issues that match your filters.

          Category
          Status