Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function __construct($object_id = 0, $object_type = null, $user_id = null)
{
if (!$object_id) {
return;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($user_id === null) {
$user = Core::get_global('user');
$user_id = $user->id ?? 0;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method getBookmarks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// bookmarks are per user
$sql = "SELECT `id` FROM `bookmark` WHERE `user` = ? AND `id` = ?;";
$db_results = Dba::read($sql, array($data['user'], $data['object_id']));
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) Open
public int $id = 0;- Exclude checks
The parameter $object_type is not named in camelCase. Open
public function __construct($object_id = 0, $object_type = null, $user_id = null)
{
if (!$object_id) {
return;
}- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $object_id is not named in camelCase. Open
public function __construct($object_id = 0, $object_type = null, $user_id = null)
{
if (!$object_id) {
return;
}- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $user_id is not named in camelCase. Open
public function __construct($object_id = 0, $object_type = null, $user_id = null)
{
if (!$object_id) {
return;
}- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
Avoid variables with short names like $id. Configured minimum length is 3. Open
public int $id = 0;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}