ampache/ampache

Broadcast has 30 functions (exceeds 20 allowed). Consider refactoring.

Open

class Broadcast extends database_object implements library_item
{
    protected const DB_TABLENAME = 'broadcast';

    public int $id = 0;

The class Broadcast has 12 public methods. Consider refactoring Broadcast to keep number of public methods under 10.

Open

class Broadcast extends database_object implements library_item
{
    protected const DB_TABLENAME = 'broadcast';

    public int $id = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class Broadcast has 45 public methods and attributes. Consider reducing the number of public items to less than 45.

Open

class Broadcast extends database_object implements library_item
{
    protected const DB_TABLENAME = 'broadcast';

    public int $id = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
    public $value;
    public $something;
    public $var;
    // [... more more public attributes ...]

    public function doWork() {}
    public function doMoreWork() {}
    public function doWorkAgain() {}
    // [... more more public methods ...]
}

Avoid assigning values to variables in if clauses and the like (line '351', column '13').

Open

    public static function get_broadcast($key): ?Broadcast
    {
        $sql        = "SELECT `id` FROM `broadcast` WHERE `key` = ?";
        $db_results = Dba::read($sql, array($key));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)

Open

    public int $id = 0;

• Exclude checks
  • Disable engine
  • Disable check

The parameter $additional_params is not named in camelCase.

Open

    public function play_url($additional_params = '', $player = '', $local = false): string
    {
        unset($additional_params, $player, $local);

        return (string)$this->id;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $broadcast_id is not named in camelCase.

Open

    public function __construct($broadcast_id = 0)
    {
        if (!$broadcast_id) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $broadcast_id is not named in camelCase.

Open

    public static function get_unbroadcast_link($broadcast_id): string
    {
        $link = "<div class=\"broadcast-action\">";
        $link .= Ajax::button(
            '?page=player&action=unbroadcast&broadcast_id=' . $broadcast_id,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $user_id is not named in camelCase.

Open

    public static function get_broadcasts($user_id): array
    {
        $sql        = "SELECT `id` FROM `broadcast` WHERE `user` = ?";
        $db_results = Dba::read($sql, array($user_id));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public int $id = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The parameter $filter_type is not named in camelCase.

Open

    public function get_medias(?string  $filter_type = null): array
    {
        // Not a media, shouldn't be that
        $medias = array();
        if ($filter_type === null || $filter_type === 'broadcast') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $song_id is not named in camelCase.

Open

    public function update_song($song_id): void
    {
        $sql = "UPDATE `broadcast` SET `song` = ? WHERE `id` = ?";
        Dba::write($sql, array($song_id, $this->id));
        $this->song          = $song_id;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}