ampache/ampache

View on GitHub
src/Repository/Model/PrivateMsg.php

Summary

Maintainability
A
0 mins
Test Coverage

syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private int $id = 0;
Severity: Critical
Found in src/Repository/Model/PrivateMsg.php by phan

The parameter $pm_id is not named in camelCase.
Open

    public function __construct($pm_id = 0)
    {
        if (!$pm_id) {
            return;
        }
Severity: Minor
Found in src/Repository/Model/PrivateMsg.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    private int $id = 0;
Severity: Minor
Found in src/Repository/Model/PrivateMsg.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status