Function display_art
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public function display_art($thumb = 2, $force = false): void
{
$episode_id = null;
$type = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function insert
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public static function insert(array $data, ?array $gtypes = array(), ?array $options = array()): int
{
if (empty($data['tvshow'])) {
$data['tvshow'] = T_('Unknown');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method insert() has an NPath complexity of 288. The configured NPath complexity threshold is 200. Open
public static function insert(array $data, ?array $gtypes = array(), ?array $options = array()): int
{
if (empty($data['tvshow'])) {
$data['tvshow'] = T_('Unknown');
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method insert() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
public static function insert(array $data, ?array $gtypes = array(), ?array $options = array()): int
{
if (empty($data['tvshow'])) {
$data['tvshow'] = T_('Unknown');
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid unused parameters such as '$gtypes'. Open
public static function insert(array $data, ?array $gtypes = array(), ?array $options = array()): int
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST)
Open
public ?string $original_name;
- Exclude checks
The method display_art uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$season = new TVShow_Season($this->season);
if (Art::has_db($season->tvshow, 'tvshow') || $force) {
$episode_id = $season->tvshow;
$type = 'tvshow';
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method display_art uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (Art::has_db($this->season, 'tvshow_season')) {
$episode_id = $this->season;
$type = 'tvshow_season';
} else {
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The class TVShow_Episode is not named in CamelCase. Open
class TVShow_Episode extends Video
{
protected const DB_TABLENAME = 'tvshow_episode';
public ?string $original_name;
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
The parameter $episode_id is not named in camelCase. Open
public function __construct($episode_id = 0)
{
if (!$episode_id) {
return;
}
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
Class name "TVShow_Episode" is not in camel caps format Open
class TVShow_Episode extends Video
- Exclude checks