ampache/ampache

Method set_items has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function set_items($playlist, $current_type, $current_id, $current_time, $time): void

syntax error, unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)

Open

    public int $user;

• Exclude checks
  • Disable engine
  • Disable check

The parameter $object_type is not named in camelCase.

Open

    public function set_current_object($object_type, $object_id, $position): void
    {
        // remove the old current
        $sql = "UPDATE `user_playlist` SET `current_track` = 0, `current_time` = 0 WHERE `user` = ?";
        Dba::write($sql, array($this->user));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $current_type is not named in camelCase.

Open

    public function set_items($playlist, $current_type, $current_id, $current_time, $time): void
    {
        if (!empty($playlist)) {
            // clear the old list
            $this->clear();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The class User_Playlist is not named in CamelCase.

Open

class User_Playlist extends database_object
{
    protected const DB_TABLENAME = 'user_playlist';

    public int $user;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

The parameter $current_time is not named in camelCase.

Open

    public function set_items($playlist, $current_type, $current_id, $current_time, $time): void
    {
        if (!empty($playlist)) {
            // clear the old list
            $this->clear();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $object_id is not named in camelCase.

Open

    public function set_current_object($object_type, $object_id, $position): void
    {
        // remove the old current
        $sql = "UPDATE `user_playlist` SET `current_track` = 0, `current_time` = 0 WHERE `user` = ?";
        Dba::write($sql, array($this->user));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $object_type is not named in camelCase.

Open

    public function set_current_id($object_type, $track, $position): void
    {
        // remove the old current
        $sql = "UPDATE `user_playlist` SET `current_track` = 0, `current_time` = 0 WHERE `user` = ?";
        Dba::write($sql, array($this->user));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $user_id is not named in camelCase.

Open

    public function __construct($user_id = 0, $client = null)
    {
        if (!$user_id) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $current_id is not named in camelCase.

Open

    public function set_items($playlist, $current_type, $current_id, $current_time, $time): void
    {
        if (!empty($playlist)) {
            // clear the old list
            $this->clear();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Class name "User_Playlist" is not in camel caps format

Open

class User_Playlist extends database_object

• Exclude checks
  • Disable engine
  • Disable check