Sign upLogin

ampache/ampache

View on GitHub
Star
src/Repository/Model/playable_item.php

Summary

Maintainability
A
0 mins
Test Coverage

Return type of get_medias() is undeclared type \Ampache\Repository\Model\list<array></array>
Open

    public function get_medias(?string $filter_type = null): array;
Severity: Minor
Found in src/Repository/Model/playable_item.php by phan

Doc-block of get_medias contains declared return type \Ampache\Repository\Model\list<array></array> which is incompatible with the return type array declared in the signature
Open

     * @return list<array{object_type: string, object_id: int}>
Severity: Minor
Found in src/Repository/Model/playable_item.php by phan

The parameter $filter_type is not named in camelCase.
Open

    public function get_medias(?string $filter_type = null): array;
Severity: Minor
Found in src/Repository/Model/playable_item.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The class playable_item is not named in CamelCase.
Open

interface playable_item
{
    /**
     * format
     *
Severity: Minor
Found in src/Repository/Model/playable_item.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Interface name "playable_item" is not in camel caps format
Open

interface playable_item
Severity: Minor
Found in src/Repository/Model/playable_item.php by phpcodesniffer

There are no issues that match your filters.

Category
Status