amtgard/ORK3

View on GitHub
import/import.ork2.wl.php

Summary

Maintainability
A
3 hrs
Test Coverage

Showing 3 of 3 total issues

Function FindOrk2Player has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function FindOrk2Player($ork3_id, $aname, $fname, $lname, $chapter) {
if (array_key_exists($chapter, $this->chapterMap)) {
$sql = "
select *
from ORKplayers
Severity: Minor
Found in import/import.ork2.wl.php - About 1 hr to fix

Method FindOrk2Player has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function FindOrk2Player($ork3_id, $aname, $fname, $lname, $chapter) {
if (array_key_exists($chapter, $this->chapterMap)) {
$sql = "
select *
from ORKplayers
Severity: Minor
Found in import/import.ork2.wl.php - About 1 hr to fix

    Method FindOrk2Player has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function FindOrk2Player($ork3_id, $aname, $fname, $lname, $chapter) {
    Severity: Minor
    Found in import/import.ork2.wl.php - About 35 mins to fix
      Category
      Status