Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/Yapo2/Driver/action.PostGis.Save.php

Summary

Maintainability
F
3 days
Test Coverage

Function update_base has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    protected function update_base() {
        $sql = "update {$this->Core->__table} set ";
        $fields = array();
        $update_fields = array();
        foreach ($this->Core->__field_actions as $field => $comparator) {
Severity: Minor
Found in system/lib/Yapo2/Driver/action.PostGis.Save.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function insert has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    protected function insert() {
        $sql = "insert into {$this->Core->__table} ";
        $insert_fields = array();
        foreach ($this->Core->__definition as $field => $definition) {
            if (isset($definition['Null']) && strtoupper($definition['Null']) == 'NO') {
Severity: Minor
Found in system/lib/Yapo2/Driver/action.PostGis.Save.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insert has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function insert() {
        $sql = "insert into {$this->Core->__table} ";
        $insert_fields = array();
        foreach ($this->Core->__definition as $field => $definition) {
            if (isset($definition['Null']) && strtoupper($definition['Null']) == 'NO') {
Severity: Major
Found in system/lib/Yapo2/Driver/action.PostGis.Save.php - About 2 hrs to fix

    Method update_base has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function update_base() {
        $sql = "update {$this->Core->__table} set ";
        $fields = array();
        $update_fields = array();
        foreach ($this->Core->__field_actions as $field => $comparator) {
    Severity: Major
    Found in system/lib/Yapo2/Driver/action.PostGis.Save.php - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                                      if (count($value->elements) == 1 && is_string($value->elements[0]))
                                    $polygon = $value->elements[0];
                                else if (is_array($value->elements[0]) && count($value->elements[0]) > 0 && is_array($value->elements[0][0])) {
                                    $polygon = implode(',', array_map(function($e) { return "$e[0] $e[1]"; }, $value->elements[0])) . ",{$value->elements[0][0][0]} {$value->elements[0][0][1]}";
                                } else {
      Severity: Major
      Found in system/lib/Yapo2/Driver/action.PostGis.Save.php and 1 other location - About 6 hrs to fix
      system/lib/Yapo2/Driver/action.PostGis.Save.php on lines 49..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 217.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                                  if (count($value->elements) == 1 && is_string($value->elements[0]))
                                $polygon = $value->elements[0];
                            else if (is_array($value->elements[0]) && count($value->elements[0]) > 0 && is_array($value->elements[0][0])) {
                                $polygon = implode(',', array_map(function($e) { return "$e[0] $e[1]"; }, $value->elements[0])) . ",{$value->elements[0][0][0]} {$value->elements[0][0][1]}";
                            } else {
      Severity: Major
      Found in system/lib/Yapo2/Driver/action.PostGis.Save.php and 1 other location - About 6 hrs to fix
      system/lib/Yapo2/Driver/action.PostGis.Save.php on lines 103..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 217.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                                  if (is_string($value->elements))
                                $linestring = $value->elements;
                            else if (is_array($value->elements)) {
                                $linestring = implode(',', array_map(function($e) { return "$e[0] $e[1]"; }, $value->elements));
                            } else {
      Severity: Major
      Found in system/lib/Yapo2/Driver/action.PostGis.Save.php and 1 other location - About 1 hr to fix
      system/lib/Yapo2/Driver/action.PostGis.Save.php on lines 90..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                                      if (is_string($value->elements))
                                    $linestring = $value->elements;
                                else if (is_array($value->elements)) {
                                    $linestring = implode(',', array_map(function($e) { return "$e[0] $e[1]"; }, $value->elements));
                                } else {
      Severity: Major
      Found in system/lib/Yapo2/Driver/action.PostGis.Save.php and 1 other location - About 1 hr to fix
      system/lib/Yapo2/Driver/action.PostGis.Save.php on lines 36..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status