Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/nusoap/nusoapmime.php

Summary

Maintainability
F
6 days
Test Coverage

Function getHTTPBody has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    function getHTTPBody($soapmsg) {
        if (count($this->requestAttachments) > 0) {
            $params['content_type'] = 'multipart/related; type="text/xml"';
            $mimeMessage = new Mail_mimePart('', $params);
            unset($params);
Severity: Minor
Found in system/lib/nusoap/nusoapmime.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getHTTPBody has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    function getHTTPBody($soapmsg) {
        if (count($this->responseAttachments) > 0) {
            $params['content_type'] = 'multipart/related; type="text/xml"';
            $mimeMessage = new Mail_mimePart('', $params);
            unset($params);
Severity: Minor
Found in system/lib/nusoap/nusoapmime.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getHTTPBody has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function getHTTPBody($soapmsg) {
        if (count($this->requestAttachments) > 0) {
            $params['content_type'] = 'multipart/related; type="text/xml"';
            $mimeMessage = new Mail_mimePart('', $params);
            unset($params);
Severity: Minor
Found in system/lib/nusoap/nusoapmime.php - About 1 hr to fix

    Method getHTTPBody has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function getHTTPBody($soapmsg) {
        if (count($this->responseAttachments) > 0) {
            $params['content_type'] = 'multipart/related; type="text/xml"';
            $mimeMessage = new Mail_mimePart('', $params);
            unset($params);
    Severity: Minor
    Found in system/lib/nusoap/nusoapmime.php - About 1 hr to fix

      Method parseResponse has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function parseResponse($headers, $data) {
        $this->debug('Entering parseResponse() for payload of length ' . strlen($data) . ' and type of ' . $headers['content-type']);
        $this->responseAttachments = array();
        if (strstr($headers['content-type'], 'multipart/related')) {
            $this->debug('Decode multipart/related');
      Severity: Minor
      Found in system/lib/nusoap/nusoapmime.php - About 1 hr to fix

        Function parseResponse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            function parseResponse($headers, $data) {
        $this->debug('Entering parseResponse() for payload of length ' . strlen($data) . ' and type of ' . $headers['content-type']);
        $this->responseAttachments = array();
        if (strstr($headers['content-type'], 'multipart/related')) {
            $this->debug('Decode multipart/related');
        Severity: Minor
        Found in system/lib/nusoap/nusoapmime.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parseRequest has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            function parseRequest($headers, $data) {
        $this->debug('Entering parseRequest() for payload of length ' . strlen($data) . ' and type of ' . $headers['content-type']);
        $this->requestAttachments = array();
        if (strstr($headers['content-type'], 'multipart/related')) {
            $this->debug('Decode multipart/related');
        Severity: Minor
        Found in system/lib/nusoap/nusoapmime.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parseRequest has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function parseRequest($headers, $data) {
        $this->debug('Entering parseRequest() for payload of length ' . strlen($data) . ' and type of ' . $headers['content-type']);
        $this->requestAttachments = array();
        if (strstr($headers['content-type'], 'multipart/related')) {
            $this->debug('Decode multipart/related');
        Severity: Minor
        Found in system/lib/nusoap/nusoapmime.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function getHTTPBody($soapmsg) {
        if (count($this->responseAttachments) > 0) {
            $params['content_type'] = 'multipart/related; type="text/xml"';
            $mimeMessage = new Mail_mimePart('', $params);
            unset($params);
          Severity: Major
          Found in system/lib/nusoap/nusoapmime.php and 1 other location - About 1 day to fix
          system/lib/nusoap/nusoapmime.php on lines 133..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 407.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function getHTTPBody($soapmsg) {
        if (count($this->requestAttachments) > 0) {
            $params['content_type'] = 'multipart/related; type="text/xml"';
            $mimeMessage = new Mail_mimePart('', $params);
            unset($params);
          Severity: Major
          Found in system/lib/nusoap/nusoapmime.php and 1 other location - About 1 day to fix
          system/lib/nusoap/nusoapmime.php on lines 363..412

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 407.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function addAttachment($data, $filename = '', $contenttype = 'application/octet-stream', $cid = false) {
        if (! $cid) {
            $cid = md5(uniqid(time()));
        }
          Severity: Major
          Found in system/lib/nusoap/nusoapmime.php and 1 other location - About 1 hr to fix
          system/lib/nusoap/nusoapmime.php on lines 88..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function addAttachment($data, $filename = '', $contenttype = 'application/octet-stream', $cid = false) {
        if (! $cid) {
            $cid = md5(uniqid(time()));
        }
          Severity: Major
          Found in system/lib/nusoap/nusoapmime.php and 1 other location - About 1 hr to fix
          system/lib/nusoap/nusoapmime.php on lines 318..331

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (!isset($part->disposition) && (strstr($part->headers['content-type'], 'text/xml'))) {
                    $this->debug('Have root part of type ' . $part->headers['content-type']);
                    $return = parent::parseRequest($part->headers, $part->body);
                } else {
                    $this->debug('Have an attachment of type ' . $part->headers['content-type']);
          Severity: Major
          Found in system/lib/nusoap/nusoapmime.php and 1 other location - About 1 hr to fix
          system/lib/nusoap/nusoapmime.php on lines 240..251

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (!isset($part->disposition) && (strstr($part->headers['content-type'], 'text/xml'))) {
                    $this->debug('Have root part of type ' . $part->headers['content-type']);
                    $root = $part->body;
                    $return = parent::parseResponse($part->headers, $part->body);
                } else {
          Severity: Major
          Found in system/lib/nusoap/nusoapmime.php and 1 other location - About 1 hr to fix
          system/lib/nusoap/nusoapmime.php on lines 470..480

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status