Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/ork3/class.Calendar.php

Summary

Maintainability
C
1 day
Test Coverage

Function _park_days has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function _park_days($start_date, $period) {
        $sql = "
                select 
                        park.name, park.park_id, recurrence, week_of_month, week_day, month_day, purpose, description, time 
                    from " . DB_PREFIX . "park park
Severity: Minor
Found in system/lib/ork3/class.Calendar.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _park_days has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _park_days($start_date, $period) {
        $sql = "
                select 
                        park.name, park.park_id, recurrence, week_of_month, week_day, month_day, purpose, description, time 
                    from " . DB_PREFIX . "park park
Severity: Minor
Found in system/lib/ork3/class.Calendar.php - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function NextWeek($request) {
        $sql = "select event.event_id, event.name, detail.event_start, detail.event_end, detail.url, detail.description from " . DB_PREFIX . "event event left join " . DB_PREFIX . "event_calendardetail detail on detail.event_id = event.event_id where event_start >= '" . mysql_real_escape_string($request['Date']) ."' and event_end <= date_add('" . mysql_real_escape_string($request['Date']) ."', interval 7 day)";
        return array('Status'=>Success(), 'Dates' => array_merge($this->_make_calendar_set($sql), $this->_park_days(strtotime($request['Date']), 'week')));
    }
    Severity: Major
    Found in system/lib/ork3/class.Calendar.php and 2 other locations - About 2 hrs to fix
    system/lib/ork3/class.Calendar.php on lines 22..25
    system/lib/ork3/class.Calendar.php on lines 27..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function NextYear($request) {
        $sql = "select event.event_id, event.name, detail.event_start, detail.event_end, detail.url, detail.description from " . DB_PREFIX . "event event left join " . DB_PREFIX . "event_calendardetail detail on detail.event_id = event.event_id where event_start >= '" . mysql_real_escape_string($request['Date']) ."' and event_end <= date_add('" . mysql_real_escape_string($request['Date']) ."', interval 1 year)";
        return array('Status'=>Success(), 'Dates' => array_merge($this->_make_calendar_set($sql), $this->_park_days(strtotime($request['Date']), 'year')));
    }
    Severity: Major
    Found in system/lib/ork3/class.Calendar.php and 2 other locations - About 2 hrs to fix
    system/lib/ork3/class.Calendar.php on lines 17..20
    system/lib/ork3/class.Calendar.php on lines 22..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function NextMonth($request) {
        $sql = "select event.event_id, event.name, detail.event_start, detail.event_end, detail.url, detail.description from " . DB_PREFIX . "event event left join " . DB_PREFIX . "event_calendardetail detail on detail.event_id = event.event_id where event_start >= '" . mysql_real_escape_string($request['Date']) ."' and event_end <= date_add('" . mysql_real_escape_string($request['Date']) ."', interval 1 month)";
        return array('Status'=>Success(), 'Dates' => array_merge($this->_make_calendar_set($sql), $this->_park_days(strtotime($request['Date']), 'month')));
    }
    Severity: Major
    Found in system/lib/ork3/class.Calendar.php and 2 other locations - About 2 hrs to fix
    system/lib/ork3/class.Calendar.php on lines 17..20
    system/lib/ork3/class.Calendar.php on lines 27..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status