Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/ork3/class.Event.php

Summary

Maintainability
F
5 days
Test Coverage

File class.Event.php has 413 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Event  extends Ork3 {

    public function __construct() {
Severity: Minor
Found in system/lib/ork3/class.Event.php - About 5 hrs to fix

    Function CreateEvent has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function CreateEvent($request) {
        logtrace("CreateEvent()", $request);
        $log = '';
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        // Common event setup
    Severity: Minor
    Found in system/lib/ork3/class.Event.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function SetEvent has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        public function SetEvent($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        
        if (valid_id($mundane_id) && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_EVENT, $request['EventId'], AUTH_EDIT)) {
                $this->event->clear();
    Severity: Minor
    Found in system/lib/ork3/class.Event.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method PlayAmtgard has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function PlayAmtgard($request) {
        $key = Ork3::$Lib->ghettocache->key($request);
        if (($cache = Ork3::$Lib->ghettocache->get(__CLASS__ . '.' . __FUNCTION__, $key, 60)) !== false)
            return $cache;
    Severity: Major
    Found in system/lib/ork3/class.Event.php - About 2 hrs to fix

      Method CreateEvent has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function CreateEvent($request) {
        logtrace("CreateEvent()", $request);
        $log = '';
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        // Common event setup
      Severity: Minor
      Found in system/lib/ork3/class.Event.php - About 1 hr to fix

        Method SetEventDetails has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function SetEventDetails($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);

        logtrace("SetEventDetails()",$request);
        Severity: Minor
        Found in system/lib/ork3/class.Event.php - About 1 hr to fix

          Method CreateEventDetails has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function CreateEventDetails($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);

        if ($mundane_id > 0 && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_EVENT, $request['EventId'], AUTH_CREATE)) {
            if (valid_id($request['Current']) && valid_id($request['EventId'])) {
          Severity: Minor
          Found in system/lib/ork3/class.Event.php - About 1 hr to fix

            Function SetEventDetails has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function SetEventDetails($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);

        logtrace("SetEventDetails()",$request);
            Severity: Minor
            Found in system/lib/ork3/class.Event.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method GetEventDetails has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function GetEventDetails($request) {
        $this->detail->clear();
        $this->detail->event_id = $request['EventId'];
        if ($request['Current']) $this->detail->current = 1;
        $response = array();
            Severity: Minor
            Found in system/lib/ork3/class.Event.php - About 1 hr to fix

              Method GetEventDetail has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function GetEventDetail($request) {
        logtrace("GetEventDetail()", $request);
        $this->detail->clear();
        $this->detail->event_calendardetail_id = $request['EventCalendarDetailId'];
        $response = array();
              Severity: Minor
              Found in system/lib/ork3/class.Event.php - About 1 hr to fix

                Function SetCurrent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function SetCurrent($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        
        $this->detail->clear();
        $this->detail->event_calendardetail_id = $request['EventCalendarDetailId'];
                Severity: Minor
                Found in system/lib/ork3/class.Event.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method SetEvent has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function SetEvent($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        
        if (valid_id($mundane_id) && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_EVENT, $request['EventId'], AUTH_EDIT)) {
                $this->event->clear();
                Severity: Minor
                Found in system/lib/ork3/class.Event.php - About 1 hr to fix

                  Function CreateEventDetails has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function CreateEventDetails($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);

        if ($mundane_id > 0 && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_EVENT, $request['EventId'], AUTH_CREATE)) {
            if (valid_id($request['Current']) && valid_id($request['EventId'])) {
                  Severity: Minor
                  Found in system/lib/ork3/class.Event.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method GetEvents has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function GetEvents($request) {
        $this->event->clear();
        if (isset($request['LimitTo']) && $request['LimitTo'] === true) {
            $this->event->kingdom_id = 0;
            $this->event->park_id = 0;
                  Severity: Minor
                  Found in system/lib/ork3/class.Event.php - About 1 hr to fix

                    Method SetCurrent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function SetCurrent($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        
        $this->detail->clear();
        $this->detail->event_calendardetail_id = $request['EventCalendarDetailId'];
                    Severity: Minor
                    Found in system/lib/ork3/class.Event.php - About 1 hr to fix

                      Function GetEvents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function GetEvents($request) {
        $this->event->clear();
        if (isset($request['LimitTo']) && $request['LimitTo'] === true) {
            $this->event->kingdom_id = 0;
            $this->event->park_id = 0;
                      Severity: Minor
                      Found in system/lib/ork3/class.Event.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function DeleteEventDetail has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function DeleteEventDetail($request) {
        $mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token']);
        
        $this->detail->clear();
        $this->detail->event_calendardetail_id = $request['EventCalendarDetailId'];
                      Severity: Minor
                      Found in system/lib/ork3/class.Event.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if ($r !== false && $r->size() > 0) {
            $response['ParkDays'] = array();
            do {
                $response['ParkDays'][] = array(
                        'EventId' => $r->event_id,
                      Severity: Major
                      Found in system/lib/ork3/class.Event.php and 1 other location - About 1 day to fix
                      system/lib/ork3/class.Park.php on lines 428..462

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 264.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status