Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/ork3/class.Unit.php

Summary

Maintainability
D
2 days
Test Coverage

File class.Unit.php has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Unit extends Ork3 {

    public function __construct() {
Severity: Minor
Found in system/lib/ork3/class.Unit.php - About 3 hrs to fix

    Function AddAward has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function AddAward($request) {
        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) == 0)
            return NoAuthorization();

        $mundane = new yapo($this->db, DB_PREFIX . 'mundane');
    Severity: Minor
    Found in system/lib/ork3/class.Unit.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method AddAward has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function AddAward($request) {
        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) == 0)
            return NoAuthorization();

        $mundane = new yapo($this->db, DB_PREFIX . 'mundane');
    Severity: Minor
    Found in system/lib/ork3/class.Unit.php - About 1 hr to fix

      Method CreateUnit has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function CreateUnit($request) {
        logtrace("CreateUnit()", $request);
        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0) {

            $this->unit->clear();
      Severity: Minor
      Found in system/lib/ork3/class.Unit.php - About 1 hr to fix

        Function CreateUnit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function CreateUnit($request) {
        logtrace("CreateUnit()", $request);
        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0) {

            $this->unit->clear();
        Severity: Minor
        Found in system/lib/ork3/class.Unit.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_member_h has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function add_member_h($request) {
        logtrace("add_member_h", $request);
        $this->unit->clear();
        $this->unit->unit_id = $request['UnitId'];
        Severity: Minor
        Found in system/lib/ork3/class.Unit.php - About 1 hr to fix

          Function RetireMember has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function RetireMember($request) {
        logtrace("RetireMember", $request);
        list($member_id, $unit_id) = $this->_translate_unitmundane($request['UnitMundaneId']);
        logtrace('Retire Member:', array($member_id, $unit_id));
        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0
          Severity: Minor
          Found in system/lib/ork3/class.Unit.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function RemoveMember has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function RemoveMember($request) {
        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0
                && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_UNIT, $request['UnitId'], AUTH_CREATE)) {
            $this->members->clear();
            $this->members->unit_mundane_id = $request['UnitMundaneId'];
          Severity: Minor
          Found in system/lib/ork3/class.Unit.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ConvertToHousehold has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function ConvertToHousehold($request) {
        logtrace('ConvertToHousehold', $request);
        $mundane = Ork3::$Lib->player->player_info($request['Token']);

        if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0
          Severity: Minor
          Found in system/lib/ork3/class.Unit.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return NoAuthorization('No Authorization');
          Severity: Major
          Found in system/lib/ork3/class.Unit.php - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0
            && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_UNIT, $request['FromUnitId'], AUTH_CREATE)
            && Ork3::$Lib->authorization->HasAuthority($mundane_id, AUTH_UNIT, $request['ToUnitId'], AUTH_CREATE)) {

            $sql = "update " . DB_PREFIX ."unit_mundane set unit_id = '" . mysql_real_escape_string($request['ToUnitId']) . "' where unit_id = '" . mysql_real_escape_string($request['FromUnitId']) . "'";
            Severity: Minor
            Found in system/lib/ork3/class.Unit.php and 1 other location - About 40 mins to fix
            system/lib/ork3/class.Park.php on lines 42..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 93.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (valid_id($request['GivenById'])) {
                $awards->park_id = valid_id($given_by['Player']['ParkId'])?$given_by['Player']['ParkId']:0;
                // If no event and valid parkid, go Park! Otherwise, go Kingdom.  Unless it's an event.  Then go ... ZERO!
                $awards->kingdom_id = valid_id($given_by['Player']['KingdomId'])?$given_by['Player']['KingdomId']:0;
            }
            Severity: Minor
            Found in system/lib/ork3/class.Unit.php and 1 other location - About 35 mins to fix
            system/lib/ork3/class.Player.php on lines 1114..1118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status