Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/phpqrcode/qrinput.php

Summary

Maintainability
F
1 mo
Test Coverage

File qrinput.php has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * PHP QR Code encoder
 *
 * Input encoding class
Severity: Major
Found in system/lib/phpqrcode/qrinput.php - About 1 day to fix

    QRinput has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

        class QRinput {

        public $items;
        
        private $version;
    Severity: Minor
    Found in system/lib/phpqrcode/qrinput.php - About 3 hrs to fix

      Function lengthOfCode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

              public static function lengthOfCode($mode, $version, $bits)
        {
            $payload = $bits - 4 - QRspec::lengthIndicator($mode, $version);
            switch($mode) {
                case QR_MODE_NUM:
      Severity: Minor
      Found in system/lib/phpqrcode/qrinput.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method lengthOfCode has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static function lengthOfCode($mode, $version, $bits)
        {
            $payload = $bits - 4 - QRspec::lengthIndicator($mode, $version);
            switch($mode) {
                case QR_MODE_NUM:
      Severity: Minor
      Found in system/lib/phpqrcode/qrinput.php - About 1 hr to fix

        Function convertData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

                public function convertData()
        {
            $ver = $this->estimateVersion();
            if($ver > $this->getVersion()) {
                $this->setVersion($ver);
        Severity: Minor
        Found in system/lib/phpqrcode/qrinput.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function encodeBitStream has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

                public function encodeBitStream($version)
        {
            try {
            
                unset($this->bstream);
        Severity: Minor
        Found in system/lib/phpqrcode/qrinput.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method encodeBitStream has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public function encodeBitStream($version)
        {
            try {
            
                unset($this->bstream);
        Severity: Minor
        Found in system/lib/phpqrcode/qrinput.php - About 1 hr to fix

          Method appendPaddingBit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public function appendPaddingBit(&$bstream)
        {
            $bits = $bstream->size();
            $maxwords = QRspec::getDataLength($this->version, $this->level);
            $maxbits = $maxwords * 8;
          Severity: Minor
          Found in system/lib/phpqrcode/qrinput.php - About 1 hr to fix

            Function appendPaddingBit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                    public function appendPaddingBit(&$bstream)
        {
            $bits = $bstream->size();
            $maxwords = QRspec::getDataLength($this->version, $this->level);
            $maxbits = $maxwords * 8;
            Severity: Minor
            Found in system/lib/phpqrcode/qrinput.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                    public static function check($mode, $size, $data)
        {
            if($size <= 0) 
                return false;
            Severity: Minor
            Found in system/lib/phpqrcode/qrinput.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function checkModeKanji has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                    public static function checkModeKanji($size, $data)
        {
            if($size & 1)
                return false;
            Severity: Minor
            Found in system/lib/phpqrcode/qrinput.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            case QR_MODE_STRUCTURE: return true; break;
            Severity: Major
            Found in system/lib/phpqrcode/qrinput.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in system/lib/phpqrcode/qrinput.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                case QR_MODE_8:         return true; break;
                Severity: Major
                Found in system/lib/phpqrcode/qrinput.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $ret;
                  Severity: Major
                  Found in system/lib/phpqrcode/qrinput.php - About 30 mins to fix

                    Function calcParity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                            public function calcParity()
        {
            $parity = 0;
            
            foreach($this->items as $item) {
                    Severity: Minor
                    Found in system/lib/phpqrcode/qrinput.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function estimateBitStreamSizeOfEntry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                            public function estimateBitStreamSizeOfEntry($version)
        {
            $bits = 0;

            if($version == 0)
                    Severity: Minor
                    Found in system/lib/phpqrcode/qrinput.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function encodeModeNum has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                            public function encodeModeNum($version)
        {
            try {
            
                $words = (int)($this->size / 3);
                    Severity: Minor
                    Found in system/lib/phpqrcode/qrinput.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        class QRinput {

        public $items;
        
        private $version;
                    Severity: Major
                    Found in system/lib/phpqrcode/qrinput.php and 1 other location - About 2 wks to fix
                    system/lib/phpqrcode/phpqrcode.php on lines 1287..1739

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 2812.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        class QRinputItem {
    
        public $mode;
        public $size;
        public $data;
                    Severity: Major
                    Found in system/lib/phpqrcode/qrinput.php and 1 other location - About 1 wk to fix
                    system/lib/phpqrcode/phpqrcode.php on lines 1044..1283

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 1961.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status