Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/phpqrcode/qrrscode.php

Summary

Maintainability
F
1 wk
Test Coverage

Function init_rs_char has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public static function init_rs_char($symsize, $gfpoly, $fcr, $prim, $nroots, $pad)
        {
            // Common code for intializing a Reed-Solomon control block (char or int symbols)
            // Copyright 2004 Phil Karn, KA9Q
            // May be used under the terms of the GNU Lesser General Public License (LGPL)
Severity: Minor
Found in system/lib/phpqrcode/qrrscode.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init_rs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        public static function init_rs($symsize, $gfpoly, $fcr, $prim, $nroots, $pad)
        {
            foreach(self::$items as $rs) {
                if($rs->pad != $pad)       continue;
                if($rs->nroots != $nroots) continue;
Severity: Minor
Found in system/lib/phpqrcode/qrrscode.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init_rs_char has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public static function init_rs_char($symsize, $gfpoly, $fcr, $prim, $nroots, $pad)
        {
            // Common code for intializing a Reed-Solomon control block (char or int symbols)
            // Copyright 2004 Phil Karn, KA9Q
            // May be used under the terms of the GNU Lesser General Public License (LGPL)
Severity: Major
Found in system/lib/phpqrcode/qrrscode.php - About 2 hrs to fix

    Method encode_rs_char has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function encode_rs_char($data, &$parity)
        {
            $MM       =& $this->mm;
            $NN       =& $this->nn;
            $ALPHA_TO =& $this->alpha_to;
    Severity: Minor
    Found in system/lib/phpqrcode/qrrscode.php - About 1 hr to fix

      Function encode_rs_char has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              public function encode_rs_char($data, &$parity)
        {
            $MM       =& $this->mm;
            $NN       =& $this->nn;
            $ALPHA_TO =& $this->alpha_to;
      Severity: Minor
      Found in system/lib/phpqrcode/qrrscode.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method init_rs_char has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public static function init_rs_char($symsize, $gfpoly, $fcr, $prim, $nroots, $pad)
      Severity: Minor
      Found in system/lib/phpqrcode/qrrscode.php - About 45 mins to fix

        Method init_rs has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public static function init_rs($symsize, $gfpoly, $fcr, $prim, $nroots, $pad)
        Severity: Minor
        Found in system/lib/phpqrcode/qrrscode.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $rs;
          Severity: Major
          Found in system/lib/phpqrcode/qrrscode.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $rs;
            Severity: Major
            Found in system/lib/phpqrcode/qrrscode.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          if($pad < 0 || $pad >= ((1<<$symsize) -1 - $nroots)) return $rs; // Too much padding
              Severity: Major
              Found in system/lib/phpqrcode/qrrscode.php - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    class QRrsItem {
    
        public $mm;                  // Bits per symbol 
        public $nn;                  // Symbols per block (= (1<<mm)-1) 
        public $alpha_to = array();  // log lookup table
                Severity: Major
                Found in system/lib/phpqrcode/qrrscode.php and 1 other location - About 6 days to fix
                system/lib/phpqrcode/phpqrcode.php on lines 2286..2438

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 1222.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    class QRrs {
    
        public static $items = array();
        
        //----------------------------------------------------------------------
                Severity: Major
                Found in system/lib/phpqrcode/qrrscode.php and 1 other location - About 4 hrs to fix
                system/lib/phpqrcode/phpqrcode.php on lines 2442..2465

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 171.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status