Sign upLogin

amtgard/ORK3

View on GitHub
Star
system/lib/phpqrcode/qrspec.php

Summary

Maintainability
F
1 mo
Test Coverage

File qrspec.php has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * PHP QR Code encoder
 *
 * QR Code specifications
Severity: Minor
Found in system/lib/phpqrcode/qrspec.php - About 6 hrs to fix

    QRspec has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

        class QRspec {
    
        public static $capacity = array(
            array(  0,    0, 0, array(   0,    0,    0,    0)),
            array( 21,   26, 0, array(   7,   10,   13,   17)), // 1
    Severity: Minor
    Found in system/lib/phpqrcode/qrspec.php - About 3 hrs to fix

      Method createFrame has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static function createFrame($version)
        {
            $width = self::$capacity[$version][QRCAP_WIDTH];
            $frameLine = str_repeat ("\0", $width);
            $frame = array_fill(0, $width, $frameLine);
      Severity: Minor
      Found in system/lib/phpqrcode/qrspec.php - About 1 hr to fix

        Function createFrame has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

                public static function createFrame($version)
        {
            $width = self::$capacity[$version][QRCAP_WIDTH];
            $frameLine = str_repeat ("\0", $width);
            $frame = array_fill(0, $width, $frameLine);
        Severity: Minor
        Found in system/lib/phpqrcode/qrspec.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method debug has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public static function debug($frame, $binary_mode = false)
        {
            if ($binary_mode) {
            
                    foreach ($frame as &$frameLine) {
        Severity: Minor
        Found in system/lib/phpqrcode/qrspec.php - About 1 hr to fix

          Function newFrame has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

                  public static function newFrame($version)
        {
            if($version < 1 || $version > QRSPEC_VERSION_MAX) 
                return null;
          Severity: Minor
          Found in system/lib/phpqrcode/qrspec.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method putAlignmentPattern has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public static function putAlignmentPattern($version, &$frame, $width)
        {
            if($version < 2)
                return;
          Severity: Minor
          Found in system/lib/phpqrcode/qrspec.php - About 1 hr to fix

            Function putAlignmentPattern has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                    public static function putAlignmentPattern($version, &$frame, $width)
        {
            if($version < 2)
                return;
            Severity: Minor
            Found in system/lib/phpqrcode/qrspec.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function maximumWords has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                    public static function maximumWords($mode, $version)
        {
            if($mode == QR_MODE_STRUCTURE) 
                return 3;
            Severity: Minor
            Found in system/lib/phpqrcode/qrspec.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function debug has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    public static function debug($frame, $binary_mode = false)
        {
            if ($binary_mode) {
            
                    foreach ($frame as &$frameLine) {
            Severity: Minor
            Found in system/lib/phpqrcode/qrspec.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function lengthIndicator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    public static function lengthIndicator($mode, $version)
        {
            if ($mode == QR_MODE_STRUCTURE)
                return 0;
            Severity: Minor
            Found in system/lib/phpqrcode/qrspec.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                class QRspec {
    
        public static $capacity = array(
            array(  0,    0, 0, array(   0,    0,    0,    0)),
            array( 21,   26, 0, array(   7,   10,   13,   17)), // 1
            Severity: Major
            Found in system/lib/phpqrcode/qrspec.php and 1 other location - About 1 mo to fix
            system/lib/phpqrcode/phpqrcode.php on lines 354..904

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 6834.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status