Sign upLogin

and3rson/telemux

View on GitHub
Star

Showing 5 of 5 total issues

Function NewConversationHandler has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

func NewConversationHandler(
    conversationID string,
    persistence ConversationPersistence,
    states StateMap,
    defaults []*Handler,
Severity: Minor
Found in handlers.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func NewRegexHandler(pattern string, filter FilterFunc, handles ...HandleFunc) *Handler {
    exp := regexp.MustCompile(pattern)
    newFilter := And(IsMessage(), func(u *Update) bool {
        return exp.Match([]byte(u.Message.Text))
    })
Severity: Major
Found in handlers.go and 2 other locations - About 2 hrs to fix
handlers.go on lines 90..105
handlers.go on lines 108..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 212.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func NewCallbackQueryHandler(pattern string, filter FilterFunc, handles ...HandleFunc) *Handler {
    exp := regexp.MustCompile(pattern)
    newFilter := And(IsCallbackQuery(), func(u *Update) bool {
        return exp.Match([]byte(u.CallbackQuery.Data))
    })
Severity: Major
Found in handlers.go and 2 other locations - About 2 hrs to fix
handlers.go on lines 46..61
handlers.go on lines 90..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 212.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func NewInlineQueryHandler(pattern string, filter FilterFunc, handles ...HandleFunc) *Handler {
    exp := regexp.MustCompile(pattern)
    newFilter := And(IsInlineQuery(), func(u *Update) bool {
        return exp.Match([]byte(u.InlineQuery.Query))
    })
Severity: Major
Found in handlers.go and 2 other locations - About 2 hrs to fix
handlers.go on lines 46..61
handlers.go on lines 108..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 212.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function NewConversationHandler has 60 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewConversationHandler(
    conversationID string,
    persistence ConversationPersistence,
    states StateMap,
    defaults []*Handler,
Severity: Minor
Found in handlers.go - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language