Sign upLogin

andela-oosiname/mastermind_sname

View on GitHub
Star

Showing 10 of 10 total issues

Method collect_user_guess has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def collect_user_guess
      puts "#{10 - @guesses.length} guess(es) left" unless @guesses.empty?
      @guess = get_input
      loop do
        @game_logic = GameLogic.new(@guess, @colours)
Severity: Minor
Found in lib/mastermind_sname/sname/game.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Redundant return detected.
Open

      when "b" then return 4
Severity: Minor
Found in lib/mastermind_sname/sname/game_colour.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Redundant return detected.
Open

      when "a" then return 8
Severity: Minor
Found in lib/mastermind_sname/sname/game_colour.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Favor a normal if-statement over a modifier clause in a multiline statement.
Open

      @colours = "(r)ed, (g)reen, (y)ellow, (b)lue, (o)"\
      "range, (v)iolet" if colours.length == 8
Severity: Minor
Found in lib/mastermind_sname/sname/message.rb by rubocop

Checks for uses of if/unless modifiers with multiple-lines bodies.

Example:

# bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond

Redundant return detected.
Open

      when "i" then return 6
Severity: Minor
Found in lib/mastermind_sname/sname/game_colour.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Script file console doesn't have execute permission.
Open

#!/usr/bin/env ruby
Severity: Minor
Found in bin/console by rubocop

Use %i or %I for an array of symbols.
Open

      valid_level = [:a, :b, :i]
Severity: Minor
Found in lib/mastermind_sname/sname/player.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
Open

        guesses: @player[:guess_count], time: @player[:time] }
Severity: Minor
Found in lib/mastermind_sname/sname/record.rb by rubocop

This cop checks that the closing brace in a hash literal is either on the same line as the last hash element, or a new line.

When using the symmetrical (default) style:

If a hash's opening brace is on the same line as the first element of the hash, then the closing brace should be on the same line as the last element of the hash.

If a hash's opening brace is on the line above the first element of the hash, then the closing brace should be on the line below the last element of the hash.

When using the new_line style:

The closing brace of a multi-line hash literal must be on the line after the last element of the hash.

When using the same_line style:

The closing brace of a multi-line hash literal must be on the same line as the last element of the hash.

Example: EnforcedStyle: symmetrical (default)

# bad
  { a: 1,
    b: 2
  }
  # bad
  {
    a: 1,
    b: 2 }

  # good
  { a: 1,
    b: 2 }

  # good
  {
    a: 1,
    b: 2
  }

Example: EnforcedStyle: new_line

# bad
  {
    a: 1,
    b: 2 }

  # bad
  { a: 1,
    b: 2 }

  # good
  { a: 1,
    b: 2
  }

  # good
  {
    a: 1,
    b: 2
  }

Example: EnforcedStyle: same_line

# bad
  { a: 1,
    b: 2
  }

  # bad
  {
    a: 1,
    b: 2
  }

  # good
  {
    a: 1,
    b: 2 }

  # good
  { a: 1,
    b: 2 }

Use %i or %I for an array of symbols.
Open

      commands = [:cheat, :exit, :h, :c, :q, :quit]
Severity: Minor
Found in lib/mastermind_sname/sname/game_logic.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Favor a normal if-statement over a modifier clause in a multiline statement.
Open

      @colours = "(r)ed, (g)reen, (y)ellow, (b)lue, (o)"\
      "range" if colours.length == 6
Severity: Minor
Found in lib/mastermind_sname/sname/message.rb by rubocop

Checks for uses of if/unless modifiers with multiple-lines bodies.

Example:

# bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond
Severity
Category
Status
Source
Language