Sign upLogin

andela/ah-infinity-stones

View on GitHub
Star
authors/apps/authentication/views.py

Summary

Maintainability
A
3 hrs
Test Coverage

File views.py has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import unicode_literals
import os
import jwt
from rest_framework import status
from rest_framework.generics import (CreateAPIView, UpdateAPIView)
Severity: Minor
Found in authors/apps/authentication/views.py - About 2 hrs to fix

    Function create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def create(self, request, *args, **kwargs):
        """Get social auth provider and token and generates the user token based on the user
         email"""
        serializer = self.serializer_class(data=request.data)
        serializer.is_valid(raise_exception=True)
    Severity: Minor
    Found in authors/apps/authentication/views.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def get(self, request, uidb64, token):
        """
        This method defines the get request once a user clicks on the
        activation link
        """
    Severity: Minor
    Found in authors/apps/authentication/views.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status