Sign upLogin

andela/ah-infinity-stones

View on GitHub
Star

Showing 26 of 26 total issues

Function get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get(self, request, art_slug, *args, **kwargs):
        """get single article"""
        try:
            article = Article.objects.get(art_slug=art_slug)
            if request.user:
Severity: Minor
Found in authors/apps/articles/views.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get(self, request, uidb64, token):
        """
        This method defines the get request once a user clicks on the
        activation link
        """
Severity: Minor
Found in authors/apps/authentication/views.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return Response({'Message': msg}, status.HTTP_204_NO_CONTENT)
Severity: Major
Found in authors/apps/articles/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return Response({'Message': msg}, status.HTTP_204_NO_CONTENT)
    Severity: Major
    Found in authors/apps/articles/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return Response({
      Severity: Major
      Found in authors/apps/articles/views.py - About 30 mins to fix

        Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def get(self, request, art_slug=None):
        """Get all the comments on an article"""
        article = get_object_or_404(Article, art_slug=self.kwargs["art_slug"])
        comment_set = Comment.objects.filter(article__id=article.id)
        comments = []
        Severity: Minor
        Found in authors/apps/comments/views.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language