Sign upLogin

andela/codepirates-ah-backend

View on GitHub
Star

Showing 67 of 142 total issues

Avoid too many return statements within this function.
Open

      return util.send(res);
Severity: Major
Found in src/middlewares/validators/signup.validation.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return util.send(res);
    Severity: Major
    Found in src/middlewares/validators/signup.validation.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return res.status(404).send({
        status: 404,
        message: error.message
      });
      Severity: Major
      Found in src/controllers/user.controller.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return util.send(res);
        Severity: Major
        Found in src/middlewares/validators/signup.validation.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return util.send(res);
          Severity: Major
          Found in src/middlewares/validators/signup.validation.js - About 30 mins to fix

            Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              static async login(req, res) {
    try {
      let theUser;

      if (req.body.email) {
            Severity: Minor
            Found in src/controllers/user.controller.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function checkBookmark has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              static async checkBookmark(req, res, next) {
    const userId = req.auth.id;
    const articleId = req.params.articleId || req.body.articleId;
    const name = req.body.oldName ? req.body.oldName : req.params.name || req.body.name;
    const bookmark = await checkItem({ userId, name, articleId });
            Severity: Minor
            Found in src/middlewares/bookmarks.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language