Sign upLogin

andela/eventx

View on GitHub
Star
app/controllers/bookings_controller.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method ticket_quantity_specified? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def ticket_quantity_specified?
    if ticket_params.values.map(&:to_i).inject(:+) <= 0
      flash[:notice] = ticket_quantity_empty
      redirect_to :back
    else
Severity: Minor
Found in app/controllers/bookings_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use %i or %I for an array of symbols.
Open

  before_action except: [:paypal_hook, :index, :each_event_ticket, :scan_ticket,
                         :use_ticket, :request_refund, :grant_refund] do
Severity: Minor
Found in app/controllers/bookings_controller.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Avoid when branches without a body.
Open

    when "INVALID"
Severity: Minor
Found in app/controllers/bookings_controller.rb by rubocop

This cop checks for the presence of when branches without a body.

Example:

# bad

case foo
when bar then 1
when baz then # nothing
end

Example:

# good

case foo
when bar then 1
when baz then 2
end

There are no issues that match your filters.

Category
Status