Sign upLogin

andrab/ecuacovid

View on GitHub
Star

Showing 29 of 29 total issues

Method register_compound_tasks has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def register_compound_tasks
      desc "Saves city positive cases pivoted"
      task generate_positives_cities_tabulated: [
        :positives_cities_accumulated_per_day_tabulated,
        :positives_cities_new_per_day_tabulated,
Severity: Major
Found in lib/ecuacovid/tasks.rb - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def mortalities
      @model = :mortalities
      @years = @filters.select {|(field, op, value)| field == :year && op == :eq}

      @includes = @filters.select {|(field, op, value)| op == :in && field == :year}
    Severity: Major
    Found in lib/ecuacovid/data.rb and 1 other location - About 2 hrs to fix
    lib/ecuacovid/data.rb on lines 40..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def positives
      @model = :positives
      @years = @filters.select {|(field, op, value)| field == :year && op == :eq}

      @includes = @filters.select {|(field, op, value)| op == :in && field == :year}
    Severity: Major
    Found in lib/ecuacovid/data.rb and 1 other location - About 2 hrs to fix
    lib/ecuacovid/data.rb on lines 64..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method prepare has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def prepare(query)
      plan = query.compile

      Class.new do
        define_method :pull do
    Severity: Minor
    Found in lib/ecuacovid/data/local_fast_store.rb - About 1 hr to fix

      Method rest has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def rest(datasets, options)
      columns = options[:columns] || []
      keep = options[:keep] || []
      keys = columns + keep
      Severity: Minor
      Found in lib/ecuacovid/table_math.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            def tabulated_rows(options)
      headers = options[:headers] || []

      options[:data].map.with_index do |subsets, idx|
        some = options[:rest][idx].filter {|v| !v.empty?}.find {|r| r.keys.any? {|l| headers.include?(l)}}
        Severity: Major
        Found in lib/ecuacovid/table.rb and 1 other location - About 1 hr to fix
        lib/ecuacovid/nu_table.rb on lines 63..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              def tabulated_rows(options)
        headers = options[:headers] || []
    
        options[:data].map.with_index do |subsets, idx|
          some = options[:rest][idx].filter {|v| !v.empty?}.find {|r| r.keys.any? {|l| headers.include?(l)}}
        Severity: Major
        Found in lib/ecuacovid/nu_table.rb and 1 other location - About 1 hr to fix
        lib/ecuacovid/table.rb on lines 67..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def headers(options={})
      cols  = rename(options[:headers], options)
      cols << rename(options[:column_names], options) unless default?(options)
      cols << rename(options[:keep], options) if default?(options)
      cols << rename(options[:new] || options[:eval], options) unless tabulated?(options)
        Severity: Minor
        Found in lib/ecuacovid/table.rb and 1 other location - About 1 hr to fix
        lib/ecuacovid/nu_table.rb on lines 29..35

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def headers(options={})
        headers  = rename(options[:headers], options)
        headers << rename(options[:column_names], options) unless default?(options)
        headers << rename(options[:keep], options) if default?(options)
        headers << rename(options[:new] || options[:eval], options) unless tabulated?(options)
        Severity: Minor
        Found in lib/ecuacovid/nu_table.rb and 1 other location - About 1 hr to fix
        lib/ecuacovid/table.rb on lines 32..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method rest has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def rest(datasets, options)
      columns = options[:columns] || []
      keep = options[:keep] || []
      keys = columns + keep
        Severity: Minor
        Found in lib/ecuacovid/table_math.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method prepare has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def prepare(query)
      plan = query.compile

      Class.new do
        define_method :pull do
        Severity: Minor
        Found in lib/ecuacovid/data/local_fast_store.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method rename has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def rename(names, replacements)
      return [] if names.nil?

      new_names = replacements[:rename] || {}
      new_names.empty? ? names : (!names.is_a?(Array) ? [names] : names).map {|name| new_names[name] || name}.compact
        Severity: Minor
        Found in lib/ecuacovid/table.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method rename has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def rename(names, replacements)
        return [] if names.nil?
    
        new_names = replacements[:rename] || {}
        new_names.empty? ? names : (!names.is_a?(Array) ? [names] : names).map {|name| new_names.fetch(name, name)}
        Severity: Minor
        Found in lib/ecuacovid/nu_table.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              def default_rows(options)
        options[:data].map.with_index do |subsets, y_idx|
          subsets.map.with_index do |data, x_idx|
            value = options[:rest][y_idx][x_idx]
            !value.empty? ? value.slice(*options[:keep]).values + [data] : nil
        Severity: Minor
        Found in lib/ecuacovid/nu_table.rb and 1 other location - About 45 mins to fix
        lib/ecuacovid/table.rb on lines 76..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            def default_rows(options)
      options[:data].map.with_index do |subsets, y_idx|
        subsets.map.with_index do |data, x_idx|
          value = options[:rest][y_idx][x_idx]
          !value.empty? ? value.slice(*options[:keep]).values + [data] : nil
        Severity: Minor
        Found in lib/ecuacovid/table.rb and 1 other location - About 45 mins to fix
        lib/ecuacovid/nu_table.rb on lines 72..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          class Positives
    attr_accessor :years, :filters
  
    def model
      :positives
        Severity: Minor
        Found in lib/ecuacovid/data.rb and 1 other location - About 35 mins to fix
        lib/ecuacovid/data.rb on lines 20..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def construct(datum, options={})
      grouped        = group(datum, options[:by] || DEFAULT_DATE)
      subtables      = split_into_subtables(grouped, options[:target])

      dates          = tags(grouped, options)
        Severity: Minor
        Found in lib/ecuacovid/table_math.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          class Mortalities
    attr_accessor :years, :filters
  
    def model
      :mortalities
        Severity: Minor
        Found in lib/ecuacovid/data.rb and 1 other location - About 35 mins to fix
        lib/ecuacovid/data.rb on lines 7..16

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method headers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def headers(options={})
        headers  = rename(options[:headers], options)
        headers << rename(options[:column_names], options) unless default?(options)
        headers << rename(options[:keep], options) if default?(options)
        headers << rename(options[:new] || options[:eval], options) unless tabulated?(options)
        Severity: Minor
        Found in lib/ecuacovid/nu_table.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method headers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def headers(options={})
      cols  = rename(options[:headers], options)
      cols << rename(options[:column_names], options) unless default?(options)
      cols << rename(options[:keep], options) if default?(options)
      cols << rename(options[:new] || options[:eval], options) unless tabulated?(options)
        Severity: Minor
        Found in lib/ecuacovid/table.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language