Sign upLogin

andrba/hungryform

View on GitHub
Star

Showing 11 of 11 total issues

Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def initialize(name, parent, resolver, attributes = {})
          @attributes = configuration.dup
          @attributes.merge!(attributes)

          @placeholders ||= {}
Severity: Minor
Found in lib/hungryform/elements/base/element.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolve_dependency has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve_dependency(dependency)
      dependency.each do |operator, arguments|
        operator = operator.to_sym

        case operator
Severity: Minor
Found in lib/hungryform/resolver.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method valid? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def valid?
          errors.clear
          is_valid = true
          return true unless visible?
Severity: Minor
Found in lib/hungryform/elements/base/group.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(name, parent, resolver, attributes = {}, &block)
Severity: Minor
Found in lib/hungryform/elements/base/group.rb - About 35 mins to fix

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def initialize(name, parent, resolver, attributes = {}, &block)
    Severity: Minor
    Found in lib/hungryform/elements/base/active_element.rb - About 35 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(name, parent, resolver, attributes = {}, &block)
      Severity: Minor
      Found in lib/hungryform/elements/page.rb - About 35 mins to fix

        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def initialize(name, parent, resolver, attributes = {}, &block)
        Severity: Minor
        Found in lib/hungryform/elements/html.rb - About 35 mins to fix

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def initialize(name, parent, resolver, attributes = {}, &block)
          Severity: Minor
          Found in lib/hungryform/elements/base/options_element.rb - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                      return !values[0].empty?
            Severity: Major
            Found in lib/hungryform/resolver.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return values[0].to_f > values[1].to_f
              Severity: Major
              Found in lib/hungryform/resolver.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return values[0].to_f < values[1].to_f
                Severity: Major
                Found in lib/hungryform/resolver.rb - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language