Sign upLogin

andrea-vinci/Insulator

View on GitHub
Star
app/src/integrationTest/kotlin/insulator/integrationtest/ConsumerGroupsTests.kt

Summary

Maintainability
B
4 hrs
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

fun testConsumer(consumerConfig: Properties, topicName: String) = object : Closeable {

    private var isRunning = true

    private val consumerThread = with(KafkaConsumer<String, String>(consumerConfig)) {
Severity: Major
Found in app/src/integrationTest/kotlin/insulator/integrationtest/ConsumerGroupsTests.kt and 1 other location - About 3 hrs to fix
lib/kafka/src/integrationTest/kotlin/insulator/integrationtest/kafka/ConsumerGroupTest.kt on lines 97..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 253.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            val consumerConfig = kafkaConfig(fixture.currentKafkaCluster).apply {
                put(ConsumerConfig.GROUP_ID_CONFIG, groupIdName)
                put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer::class.java)
            }
Severity: Minor
Found in app/src/integrationTest/kotlin/insulator/integrationtest/ConsumerGroupsTests.kt and 1 other location - About 40 mins to fix
lib/kafka/src/integrationTest/kotlin/insulator/integrationtest/kafka/ConsumerGroupTest.kt on lines 43..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

            mainView.lookupFirst<Label>(CssRule.id("consumer-$groupIdName")).text shouldBe groupIdName
Severity: Major
Found in app/src/integrationTest/kotlin/insulator/integrationtest/ConsumerGroupsTests.kt and 4 other locations - About 35 mins to fix
app/src/integrationTest/kotlin/insulator/integrationtest/CreateSchemaTests.kt on lines 59..59
app/src/integrationTest/kotlin/insulator/integrationtest/MainViewTest.kt on lines 76..76
app/src/integrationTest/kotlin/insulator/integrationtest/RefreshButtonTests.kt on lines 46..46
app/src/integrationTest/kotlin/insulator/integrationtest/RefreshButtonTests.kt on lines 62..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

            mainView.lookupFirst<Label>(CssRule.id("consumer-$groupIdName")).doubleClick()
Severity: Minor
Found in app/src/integrationTest/kotlin/insulator/integrationtest/ConsumerGroupsTests.kt and 1 other location - About 30 mins to fix
app/src/integrationTest/kotlin/insulator/integrationtest/RefreshButtonTests.kt on lines 74..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status