Sign upLogin

andreoliwa/nitpick

View on GitHub
Star
src/nitpick/generic.py

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Consider possible security implications associated with subprocess module.
Open

import subprocess
Severity: Info
Found in src/nitpick/generic.py by bandit

Starting a process with a partial executable path
Open

        output = subprocess.check_output(
            # TODO: fix: this command might not work on Windows; maybe read ~/.gitconfig directly instead?
            ["git", "config", "--get", GIT_CORE_EXCLUDES_FILE],  # noqa: S603,S607
            universal_newlines=True,
Severity: Info
Found in src/nitpick/generic.py by bandit

subprocess call - check for execution of untrusted input.
Open

        output = subprocess.check_output(
            # TODO: fix: this command might not work on Windows; maybe read ~/.gitconfig directly instead?
            ["git", "config", "--get", GIT_CORE_EXCLUDES_FILE],  # noqa: S603,S607
            universal_newlines=True,
Severity: Info
Found in src/nitpick/generic.py by bandit

Function glob_non_ignored_files has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Wontfix

def glob_non_ignored_files(root_dir: Path, pattern: str = "**/*") -> Iterable[Path]:
    """Glob all files in the root dir that are not ignored by Git."""

    git_dir = root_dir / GIT_DIR
    is_locally_ignored = None
Severity: Minor
Found in src/nitpick/generic.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status